imageloader always logs failure. |
||||||||||
Issue descriptionThere was a mistake in https://chromium-review.googlesource.com/c/chromiumos/platform/imageloader/+/690438 such that imageloader --unmount_all always logs failure. The fix is very low risk see: https://chromium-review.googlesource.com/c/chromiumos/platform/imageloader/+/701595
,
Oct 13 2017
,
Oct 13 2017
This bug requires manual review: We are only 3 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 13 2017
When this is reviewed for merge. There's no functional implication to this change, it's just going to cause confusion when folks see --unmount_all fail in the syslog all the time.
,
Oct 13 2017
,
Oct 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/imageloader/+/27ca312bb82df59772edfa6b037d661569679f03 commit 27ca312bb82df59772edfa6b037d661569679f03 Author: Allen Webb <allenwebb@google.com> Date: Fri Oct 13 17:54:53 2017 imageloader: Fix to error logging for --unmount_all. BUG= chromium:760007 BUG= chromium:773924 TEST=test_that -b amd64-generic <ip:port> platform_ImageLoaderServer Change-Id: Idf22cd6f52c00ce93a511c3ba54e9b9ea190e682 Reviewed-on: https://chromium-review.googlesource.com/713637 Commit-Ready: Allen Webb <allenwebb@google.com> Tested-by: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> (cherry picked from commit 1e51d8b63530b571c20edc37c0e336637d1f9e00) Reviewed-on: https://chromium-review.googlesource.com/718992 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Trybot-Ready: Greg Kerr <kerrnel@chromium.org> [modify] https://crrev.com/27ca312bb82df59772edfa6b037d661569679f03/imageloader_main.cc
,
Oct 17 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17 2017
,
Nov 29 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by kerrnel@chromium.org
, Oct 12 2017