New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773924 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

imageloader always logs failure.

Project Member Reported by allenwebb@chromium.org, Oct 12 2017

Issue description

There was a mistake in https://chromium-review.googlesource.com/c/chromiumos/platform/imageloader/+/690438 such that imageloader --unmount_all always logs failure. The fix is very low risk see: 

https://chromium-review.googlesource.com/c/chromiumos/platform/imageloader/+/701595
 
Labels: Merge-Request-62
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 13 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: We are only 3 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
When this is reviewed for merge. There's no functional implication to this change, it's just going to cause confusion when folks see --unmount_all fail in the syslog all the time.
Labels: -Hotlist-Merge-Review -Merge-Review-62 Merge-Approved-62
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 15 2017

Labels: merge-merged-release-R62-9901.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/imageloader/+/27ca312bb82df59772edfa6b037d661569679f03

commit 27ca312bb82df59772edfa6b037d661569679f03
Author: Allen Webb <allenwebb@google.com>
Date: Fri Oct 13 17:54:53 2017

imageloader: Fix to error logging for --unmount_all.

BUG= chromium:760007 
BUG= chromium:773924 
TEST=test_that -b amd64-generic <ip:port> platform_ImageLoaderServer

Change-Id: Idf22cd6f52c00ce93a511c3ba54e9b9ea190e682
Reviewed-on: https://chromium-review.googlesource.com/713637
Commit-Ready: Allen Webb <allenwebb@google.com>
Tested-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
(cherry picked from commit 1e51d8b63530b571c20edc37c0e336637d1f9e00)
Reviewed-on: https://chromium-review.googlesource.com/718992
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Trybot-Ready: Greg Kerr <kerrnel@chromium.org>

[modify] https://crrev.com/27ca312bb82df59772edfa6b037d661569679f03/imageloader_main.cc

Project Member

Comment 7 by sheriffbot@chromium.org, Oct 17 2017

Cc: bhthompson@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-62
Status: Fixed (was: Started)

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: archived (was: Fixed)

Comment 11 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment