This is a mechanical change.
The change removes the |manifest| parameter from the CrxInstaller::Install.
In the current implementation, the CRX manifest is read once by common code in the update_client, then it is handed over to implementors of Install, and implementors of ComponentInstallerPolicy.
The current component installers mostly ignore the manifest data. With few exceptions (which ignore the manifest data), the component installers are implemented in terms of ComponentInstaller and ComponentInstallerPolicy. This change refactors how these the component installer reads the manifest.
For future feature work, there are requirements for the manifest to be read by sandboxed code. Therefore, reading of the manifest must be happen outside the implementation of CrxInstaller::Install, so that such code can have the flexibily in how the reading of the manifest occurs.
This is a mechanical change.
The change removes the |manifest| parameter from the CrxInstaller::Install.
In the current implementation, the CRX manifest is read once by common code in the update_client, then it is handed over to implementors of Install, and implementors of ComponentInstallerPolicy.
The current component installers mostly ignore the manifest data. With few exceptions (which ignore the manifest data), the component installers are implemented in terms of ComponentInstaller and ComponentInstallerPolicy. This change refactors how the component installer reads the manifest.
For future feature work, there are requirements for the manifest to be read by sandboxed code. Therefore, reading of the manifest must be happen outside the implementation of CrxInstaller::Install, so that such code can have the flexibily in how the reading of the manifest occurs.
Comment 1 by sorin@chromium.org
, Oct 12 2017