New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773919 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 772692



Sign in to add a comment

[Findit] avoid revert chain for Findit auto_revert.

Project Member Reported by chanli@chromium.org, Oct 12 2017

Issue description

To avoid revert chain situation, Findit will not revert a culprit which is a revert already.
 

Comment 1 by chanli@chromium.org, Oct 12 2017

Blocking: 772692

Comment 2 by chanli@chromium.org, Oct 13 2017

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fa7a52f4741f5e04bba0dfccc9b8456dc572c60b

commit fa7a52f4741f5e04bba0dfccc9b8456dc572c60b
Author: Chan <chanli@chromium.org>
Date: Fri Oct 13 22:35:01 2017

[Findit] Don't revert if the culprit is a revert already.

To avoid revert chain situation, Findit will not revert a culprit which is a revert of another change.

Also, add revert_of information to cl_info.

Bug:  773919 
Change-Id: I5d50614b59ad74b2b3f135fa1a9e078c943284df
Reviewed-on: https://chromium-review.googlesource.com/714534
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/fa7a52f4741f5e04bba0dfccc9b8456dc572c60b/appengine/findit/infra_api_clients/codereview/test/gerrit_test.py
[modify] https://crrev.com/fa7a52f4741f5e04bba0dfccc9b8456dc572c60b/appengine/findit/services/revert.py
[modify] https://crrev.com/fa7a52f4741f5e04bba0dfccc9b8456dc572c60b/appengine/findit/infra_api_clients/codereview/test/cl_info_test.py
[modify] https://crrev.com/fa7a52f4741f5e04bba0dfccc9b8456dc572c60b/appengine/findit/services/test/revert_test.py
[modify] https://crrev.com/fa7a52f4741f5e04bba0dfccc9b8456dc572c60b/appengine/findit/infra_api_clients/codereview/cl_info.py
[modify] https://crrev.com/fa7a52f4741f5e04bba0dfccc9b8456dc572c60b/appengine/findit/infra_api_clients/codereview/test/rietveld_test.py
[modify] https://crrev.com/fa7a52f4741f5e04bba0dfccc9b8456dc572c60b/appengine/findit/infra_api_clients/codereview/gerrit.py

Sign in to add a comment