Make it easier to share ProximityAuth debug logs |
|||||||
Issue descriptionCurrently, users have to click "Copy to Clipboard", then paste that to a file, then send us the file. It would be easier if the file were generated automatically. https://chromium-review.googlesource.com/c/chromium/src/+/714488
,
Oct 12 2017
This bug requires manual review: We are only 4 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 12 2017
We need to see this landed in ToT and verified there first (e.g. through a Chrome OS PFQ), then we can review for 62.
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4d602a2795bcc08cd67b2415ef8622f3759d60b commit e4d602a2795bcc08cd67b2415ef8622f3759d60b Author: Kyle Horimoto <khorimoto@google.com> Date: Thu Oct 12 20:11:56 2017 [CrOS Tether] ProximityAuth debug UI: Add "Save Logs" button. This button replaces the "Copy to Clipboard" button, which was difficult to use because it required later pasting the logs to another file. Now, the logs are automatically saved to a file so that they can be shared easily by dogfooders. Change-Id: I412b6121cca82190b27e3182f29ee9e09587a761 Bug: 773900 , 672263 Reviewed-on: https://chromium-review.googlesource.com/714488 Reviewed-by: Tim Song <tengs@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#508428} [modify] https://crrev.com/e4d602a2795bcc08cd67b2415ef8622f3759d60b/components/proximity_auth/webui/resources/common.css [modify] https://crrev.com/e4d602a2795bcc08cd67b2415ef8622f3759d60b/components/proximity_auth/webui/resources/logs.js [modify] https://crrev.com/e4d602a2795bcc08cd67b2415ef8622f3759d60b/components/proximity_auth/webui/resources/proximity_auth.html
,
Oct 12 2017
Hey Bernie - actually, I just talked to jhawkins@, who suggested we do not merge this change into M-62 after all. Sorry for the noise!
,
Oct 12 2017
,
Nov 3 2017
,
Nov 6 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 6 2017
This change was merged before the M-63 branch date, so there is no need to cherry-pick it to M-63. Thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by khorimoto@chromium.org
, Oct 12 2017