New issue
Advanced search Search tips

Issue 773893 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Feature request: Add list of failing steps at top of build page

Project Member Reported by bpastene@chromium.org, Oct 11 2017

Issue description

Buildbot ui for a failing build lists the steps that failed at the top of the page:
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/280068

Milo ui does not:
https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/280068

I find this useful when I'm linked to a failing build so that I can immediately tell what went wrong without having to scan the entire set of steps. Additionally, some builds have several hundred steps and more often than not I'm only interested in the failing steps. Without the list at the top, I have to scroll all the way down until I find a failing step. With the list there, I can simply ctrl-c and ctrl-f the step name to immediately jump down to its location.
 

Comment 1 by no...@chromium.org, Oct 12 2017

Components: -Infra>Platform>Milo Infra>Platform>Milo>Buildbot
Labels: -Pri-3 Pri-2
Owner: no...@chromium.org
Status: Assigned (was: Untriaged)
looks like it is a regression https://2107-1af25a3-dot-luci-milo.appspot.com/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/
i will take a look

Comment 2 by no...@chromium.org, Oct 12 2017

Cc: no...@chromium.org
Labels: -Pri-2 Pri-3
Owner: ----
Status: Available (was: Assigned)
wrong, that's a different page. Looks like not a regression

Comment 3 by no...@chromium.org, Oct 12 2017

Labels: -Type-Bug Type-Feature

Comment 4 by hinoka@chromium.org, Oct 12 2017

Labels: -Type-Feature -Pri-3 Pri-2 Type-Bug
Owner: hinoka@chromium.org
Status: Assigned (was: Available)
Non parity between buildbot and Milo's emulation of buildbot can be considered a bug.  I'll take a look.

Comment 5 by efoo@chromium.org, Nov 21 2017

Labels: LUCI-KnownIssues-UI

Comment 6 by efoo@chromium.org, Nov 22 2017

Labels: LUCI-Blocker-UI
This appears to be a regression and not parity. Marking as Blocker for UI. 

Comment 7 by estaab@chromium.org, Nov 27 2017

Ryan, what's the status of this?
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0

commit 5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0
Author: Ryan Tseng <hinoka@google.com>
Date: Tue Nov 28 01:46:37 2017

Milo: Use Step text instead of status on build page if possible

This displays the step text instead of our custom status message if the
step text is available.  This is closer in line with previous behavior
and user expectations.

Bug:  773893 
Change-Id: Ic9edda7170d30801c90bafbd3df0b0ef370e3964
Reviewed-on: https://chromium-review.googlesource.com/792531
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/buildsource/buildbot/build.go
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/buildsource/buildbot/builder.go
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/buildsource/buildbot/expectations/CrWinGoma.30608.build.json
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/buildsource/buildbot/expectations/chromium_presubmit.426944.build.json
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/buildsource/buildbot/expectations/gerritCL.1234.build.json
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/buildsource/buildbot/expectations/newline.1234.build.json
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/buildsource/buildbot/expectations/win_chromium_rel_ng.246309.build.json
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/appengine/templates/pages/build.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/buildbot.build-Debug_page-_chromium_presubmit_426944.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/buildbot.build-Debug_page-_gerritCL_1234.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-Basic_successful_build.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-build-canceled.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-build-exception.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-build-expired.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-build-finished-logdog-expired-stream.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-build-gerrit.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-build-internal.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-build-link.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-build-nested.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-build-patch-failure.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-build-pending-logdog.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-build-pending.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-build-running-logdog-no-annotation-stream.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-build-running-logdog.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-build-running.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-build-timeout.html
[modify] https://crrev.com/5fb02a6c49ac8bae39e0197e4817b16ad9e3cda0/milo/frontend/expectations/swarming.build-build-unicode.html

Comment 9 by hinoka@chromium.org, Nov 29 2017

Status: Fixed (was: Assigned)

Comment 10 by efoo@chromium.org, Dec 5 2017

Labels: LUCI-M3-S12 LUCI-M3-Beta

Comment 11 by efoo@chromium.org, Jan 31 2018

Labels: LUCI-Beta

Comment 12 by efoo@chromium.org, Jan 31 2018

Labels: -LUCI-M3-Beta

Sign in to add a comment