New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 773890 link

Starred by 1 user
Status: Fixed
Owner:
skau@chromium.org
Closed: Oct 2017
Cc:
adlr@chromium.org
weifangsun@chromium.org
█ justincarlson@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Not Receiving Metrics For Added Printers

Project Member Reported by skau@chromium.org, Oct 11 2017 
Chrome Version: Last entry of SETUP_MANUAL in 62.3202.28.  Last SETUP_AUTOMATIC in 62.3202.18
OS: ChromeOS

PRECONDITION: Enable metrics logging

What steps will reproduce the problem?
(1) Enter printer setup
(2) Add a printer

What is the expected result?
UMA records a printer added events.

What happens instead?
Nothing

See dashboard for more info go/yyedz
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/789165cc23cf63cc850fd5940e985d0d045248ba

commit 789165cc23cf63cc850fd5940e985d0d045248ba
Author: Sean Kau <skau@chromium.org>
Date: Sat Oct 21 02:29:17 2017

Record printer installations in PrinterInstalled.

We assumed that we could record installations in UpdatePrinter.  However,
when PrinterInstalled began to imply UpdatePrinter, this prevented the
installation from being logged because the printer had already been saved
to storage.

Bug:  773890 
Change-Id: I68684fb70d983e89933b81fcc4936b82848438c9
Reviewed-on: https://chromium-review.googlesource.com/731763
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510645}
[modify] https://crrev.com/789165cc23cf63cc850fd5940e985d0d045248ba/chrome/browser/chromeos/printing/cups_printers_manager.cc

Comment 2 by skau@chromium.org, Oct 23 2017

Labels: Merge-Request-63
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 24 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 24 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/819cee878c7f812a5f795284f0a5dc717bab47c6

commit 819cee878c7f812a5f795284f0a5dc717bab47c6
Author: Sean Kau <skau@chromium.org>
Date: Tue Oct 24 18:35:10 2017

Record printer installations in PrinterInstalled.

We assumed that we could record installations in UpdatePrinter.  However,
when PrinterInstalled began to imply UpdatePrinter, this prevented the
installation from being logged because the printer had already been saved
to storage.

TBR=skau@chromium.org

(cherry picked from commit 789165cc23cf63cc850fd5940e985d0d045248ba)

Bug:  773890 
Change-Id: I68684fb70d983e89933b81fcc4936b82848438c9
Reviewed-on: https://chromium-review.googlesource.com/731763
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510645}
Reviewed-on: https://chromium-review.googlesource.com/735510
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#183}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/819cee878c7f812a5f795284f0a5dc717bab47c6/chrome/browser/chromeos/printing/cups_printers_manager.cc
►

Sign in to add a comment