New issue
Advanced search Search tips

Issue 773885 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 417782



Sign in to add a comment

[root layer scrolls] composited-scroll.js is wrong

Project Member Reported by pdr@chromium.org, Oct 11 2017

Issue description

composited-scroll.js will always report composited scrolling when root layer scrolling is enabled.

Several tests in virtual/prefer_compositing_to_lcd_text/compositing/overflow fail due to this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3a2246b2215813868dddb8e81ced3103e137f20

commit d3a2246b2215813868dddb8e81ced3103e137f20
Author: Philip Rogers <pdr@chromium.org>
Date: Thu Oct 12 19:48:39 2017

[root layer scrolls] Fix composited-scroll.js tests

composited-scroll.js checked for any scrolling contents layer
and with Root Layer Scrolling (RLS) there will always be at
least one scrolling contents layer. This patch updates
composited-scroll.js to check specific scrolling element layers
instead of the entire page's layers.

Bug:  773885 
Change-Id: I48c81c28a6dc04d2d8b749bd866125f99adf28aa
Reviewed-on: https://chromium-review.googlesource.com/714297
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508390}
[modify] https://crrev.com/d3a2246b2215813868dddb8e81ced3103e137f20/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/d3a2246b2215813868dddb8e81ced3103e137f20/third_party/WebKit/LayoutTests/compositing/overflow/ancestor-with-clip-path.html
[modify] https://crrev.com/d3a2246b2215813868dddb8e81ced3103e137f20/third_party/WebKit/LayoutTests/compositing/overflow/descendant-with-clip-path.html
[modify] https://crrev.com/d3a2246b2215813868dddb8e81ced3103e137f20/third_party/WebKit/LayoutTests/compositing/overflow/opt-in-if-composited.html
[modify] https://crrev.com/d3a2246b2215813868dddb8e81ced3103e137f20/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-background-opaque-to-transparent.html
[modify] https://crrev.com/d3a2246b2215813868dddb8e81ced3103e137f20/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-background-transparent-to-opaque.html
[modify] https://crrev.com/d3a2246b2215813868dddb8e81ced3103e137f20/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-opaque-background-will-change.html
[modify] https://crrev.com/d3a2246b2215813868dddb8e81ced3103e137f20/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-opaque-background.html
[modify] https://crrev.com/d3a2246b2215813868dddb8e81ced3103e137f20/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-pointer-events-toggle-expected.txt
[modify] https://crrev.com/d3a2246b2215813868dddb8e81ced3103e137f20/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-pointer-events-toggle.html
[modify] https://crrev.com/d3a2246b2215813868dddb8e81ced3103e137f20/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-transparent-background.html
[modify] https://crrev.com/d3a2246b2215813868dddb8e81ced3103e137f20/third_party/WebKit/LayoutTests/compositing/overflow/resources/composited-scroll.js
[modify] https://crrev.com/d3a2246b2215813868dddb8e81ced3103e137f20/third_party/WebKit/LayoutTests/compositing/overflow/scroller-with-border-radius.html

Comment 2 by pdr@chromium.org, Oct 12 2017

Status: Fixed (was: Assigned)

Comment 3 by pdr@chromium.org, Oct 12 2017

Blocking: 417782

Sign in to add a comment