New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773884 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Try job elapsed seconds aren't populated to data points

Project Member Reported by wylieb@chromium.org, Oct 11 2017

Issue description

New field that isn't populated.
 

Comment 1 by st...@chromium.org, Oct 11 2017

I think we want this eventually.

For try-job time, it is more than the Swarming task execution time, because there is also code checkout/compile/etc.

Comment 2 by wylieb@chromium.org, Oct 12 2017

Owner: lijeffrey@chromium.org
Throwing over to lijeffrey@ getting an error when writing a unit test.

  File "/usr/local/google/home/wylieb/chromium/infra-internal/infra/appengine/findit/model/flake/flake_try_job_data.py", line 23, in builder_name
    return FlakeTryJob.GetBuilderName(self.try_job_key)
  File "/usr/local/google/home/wylieb/chromium/infra-internal/infra/appengine/findit/model/base_try_job.py", line 33, in GetBuilderName
    return key.pairs()[0][1].split('/')[1]
AttributeError: 'NoneType' object has no attribute 'pairs'

Comment 3 by wylieb@chromium.org, Oct 12 2017

Code block
    try_job_data = ndb.Key(urlsafe=try_job.try_job_ids[-1]).get()
    data_point.elapsed_seconds = int(
        (try_job_data.end_time - try_job_data.start_time).total_seconds())
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 15 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment