[Findit] Flake Analyzer - Try job elapsed seconds aren't populated to data points |
|||
Issue descriptionNew field that isn't populated.
,
Oct 12 2017
Throwing over to lijeffrey@ getting an error when writing a unit test.
File "/usr/local/google/home/wylieb/chromium/infra-internal/infra/appengine/findit/model/flake/flake_try_job_data.py", line 23, in builder_name
return FlakeTryJob.GetBuilderName(self.try_job_key)
File "/usr/local/google/home/wylieb/chromium/infra-internal/infra/appengine/findit/model/base_try_job.py", line 33, in GetBuilderName
return key.pairs()[0][1].split('/')[1]
AttributeError: 'NoneType' object has no attribute 'pairs'
,
Oct 12 2017
Code block
try_job_data = ndb.Key(urlsafe=try_job.try_job_ids[-1]).get()
data_point.elapsed_seconds = int(
(try_job_data.end_time - try_job_data.start_time).total_seconds())
,
Oct 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/f336163454a30e8ac87198b3e9409d39658d46f3 commit f336163454a30e8ac87198b3e9409d39658d46f3 Author: Jeffrey Li <lijeffrey@chromium.org> Date: Fri Oct 13 21:34:24 2017 [Findit] Flake Analyzer - Include elapsed time of try jobs in data points Bug: 773884 Change-Id: Idc0327266b0ccdf85b876dea14031ae31f87f537 Reviewed-on: https://chromium-review.googlesource.com/719580 Reviewed-by: Brandon Wylie <wylieb@chromium.org> Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/f336163454a30e8ac87198b3e9409d39658d46f3/appengine/findit/waterfall/flake/process_flake_try_job_result_pipeline.py [modify] https://crrev.com/f336163454a30e8ac87198b3e9409d39658d46f3/appengine/findit/waterfall/flake/test/process_flake_try_job_result_pipeline_test.py
,
Oct 25 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by st...@chromium.org
, Oct 11 2017