New issue
Advanced search Search tips

Issue 773866 link

Starred by 2 users
Status: Fixed
Owner:
dtseng@chromium.org
Closed: Feb 2018
Cc:
dtseng@chromium.org
lpalmaro@chromium.org
Components:
EstimatedDays: ----
NextAction: 2017-10-20
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility

Blocked on:
issue 776308


Sign in to add a comment

ChromeVox not speaking when editing contents of a cell in Google Sheets

Reported by mjanusau...@afb.org, Oct 11 2017 
Mode: force_next
Version: 62.0.3202.43
Reproduction Steps: 
1. Press Enter on a cell that contains content such as a date.
2. Press left and right arrow to move the cursor to perform an edit.
3. Note that nothing is spoken as the cursor moves so  it is not possible to know where the cursor is located.

Comment 1 by leberly@chromium.org, Oct 12 2017

Components: -UI>Accessibility UI>Accessibility>ChromeVox
Labels: sheets
Status: Available (was: Unconfirmed)
ChromeOS Version 63.0.3230.0 (Official Build) canary (64-bit)
Firmware Version Google_Samus.6300.174.0

Hello,

I can reproduce this behavior and will move this bug through our triage process. Here's the steps I used: 

# Enable ChromeVox
# Create new Sheet, put today's date into one cell
# Press Enter to put cursor into the end of the cell to allow for edits
# Use left and right arrow keys to move the cursor. 

Expected: characters are spoken
Actual: no verbalization

Note that when you delete or add a character, that is spoken as expected. 

Thanks,

Laura

Comment 2 by leberly@chromium.org, Oct 12 2017 

Reproing in other environments to determine the root of the problem. 

Google Chrome	63.0.3238.0 (Official Build) canary (64-bit) (cohort: 64-Bit)
Windows 10 Enterprise Version 10.0.14393 Build 14393
JAWS 2018.1710.22 Private Beta 2

Works as expected, characters are read. This is a ChromeVox specific problem.

Comment 3 by leberly@google.com, Oct 17 2017 

Checking again in ChromeOS Version 60.0.3112.114 (Official Build) canary (64-bit)
Firmware Version Google_Lulu.6301.136.57 

It works in the older version so this is a regression. Thanks for catching this in Canary before it goes to production.

Comment 4 by leberly@google.com, Oct 17 2017 

Correction, I had a typo above (copy/paste error on my part)

I used ChromeOS Version 60.0.3112.114 (Official Build) (64-bit)
Firmware Version Google_Lulu.6301.136.57
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9af30c037704f53ac9f9a9f4d1aee30023cf6ef0

commit 9af30c037704f53ac9f9a9f4d1aee30023cf6ef0
Author: David Tseng <dtseng@chromium.org>
Date: Wed Oct 18 23:01:25 2017

Fire focus if needed in automation api

Bug:  773866 

Change-Id: I4e7295137141fa4f1605247cafb3bc4d40a09a59
Reviewed-on: https://chromium-review.googlesource.com/723606
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509911}
[modify] https://crrev.com/9af30c037704f53ac9f9a9f4d1aee30023cf6ef0/chrome/renderer/resources/extensions/automation_custom_bindings.js

Comment 6 by dtseng@chromium.org, Oct 19 2017

Status: fixed (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f515523793a9349daeebd0decb92effb05403980

commit f515523793a9349daeebd0decb92effb05403980
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Thu Oct 19 00:22:10 2017

Revert "Fire focus if needed in automation api"

This reverts commit 9af30c037704f53ac9f9a9f4d1aee30023cf6ef0.

Reason for revert: Looks like this broke SpokenFeedbackTest.ChromeVoxShiftSearch:

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/45903

Original change's description:
> Fire focus if needed in automation api
> 
> Bug:  773866 
> 
> Change-Id: I4e7295137141fa4f1605247cafb3bc4d40a09a59
> Reviewed-on: https://chromium-review.googlesource.com/723606
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509911}

TBR=dmazzoni@chromium.org,dtseng@chromium.org

Change-Id: I6f571f16e6d8015098cf5c8df96e51b2f3653580
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  773866 
Reviewed-on: https://chromium-review.googlesource.com/727439
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509938}
[modify] https://crrev.com/f515523793a9349daeebd0decb92effb05403980/chrome/renderer/resources/extensions/automation_custom_bindings.js
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b78994873aeebee7ea93602a916a10facdd0848

commit 0b78994873aeebee7ea93602a916a10facdd0848
Author: David Tseng <dtseng@chromium.org>
Date: Thu Oct 19 05:24:54 2017

Reland: Fire focus if needed in automation api

TBR=dtseng@chromium.org
Bug:  773866 

Original change

Reviewed-on: https://chromium-review.googlesource.com/723606
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509911}
Change-Id: I74c39f7d8372b623a827dff89cc20b25f6485a2f
Reviewed-on: https://chromium-review.googlesource.com/727122
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510006}
[modify] https://crrev.com/0b78994873aeebee7ea93602a916a10facdd0848/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/0b78994873aeebee7ea93602a916a10facdd0848/chrome/renderer/resources/extensions/automation_custom_bindings.js
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db2ec9cea81c4d70a06199bafa898032249da2ac

commit db2ec9cea81c4d70a06199bafa898032249da2ac
Author: Mikel Astiz <mastiz@chromium.org>
Date: Thu Oct 19 09:45:01 2017

Revert "Fire focus if needed in automation api"

This reverts commit 9af30c037704f53ac9f9a9f4d1aee30023cf6ef0.

Reason for revert: breaks Linux ChromiumOS Tests.

Bug: 776308

Original change's description:
> Fire focus if needed in automation api
> 
> Bug:  773866 
> 
> Change-Id: I4e7295137141fa4f1605247cafb3bc4d40a09a59
> Reviewed-on: https://chromium-review.googlesource.com/723606
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509911}

TBR=dmazzoni@chromium.org,dtseng@chromium.org

Change-Id: Ifb8e4267a85f573aae5891bc9916c8a2c6e33a7c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  773866 
Reviewed-on: https://chromium-review.googlesource.com/727982
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510044}
[modify] https://crrev.com/db2ec9cea81c4d70a06199bafa898032249da2ac/chrome/renderer/resources/extensions/automation_custom_bindings.js
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/499282a044a1760a55e8dbe768415e05dbb0cd43

commit 499282a044a1760a55e8dbe768415e05dbb0cd43
Author: Mikel Astiz <mastiz@chromium.org>
Date: Thu Oct 19 11:03:44 2017

Revert "Revert "Fire focus if needed in automation api""

This reverts commit db2ec9cea81c4d70a06199bafa898032249da2ac.

Reason for revert: I reverted the wrong patch, sorry for the mess. It should have been the reland patch, https://chromium-review.googlesource.com/727122

Original change's description:
> Revert "Fire focus if needed in automation api"
> 
> This reverts commit 9af30c037704f53ac9f9a9f4d1aee30023cf6ef0.
> 
> Reason for revert: breaks Linux ChromiumOS Tests.
> 
> Bug: 776308
> 
> Original change's description:
> > Fire focus if needed in automation api
> > 
> > Bug:  773866 
> > 
> > Change-Id: I4e7295137141fa4f1605247cafb3bc4d40a09a59
> > Reviewed-on: https://chromium-review.googlesource.com/723606
> > Commit-Queue: David Tseng <dtseng@chromium.org>
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#509911}
> 
> TBR=dmazzoni@chromium.org,dtseng@chromium.org
> 
> Change-Id: Ifb8e4267a85f573aae5891bc9916c8a2c6e33a7c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  773866 
> Reviewed-on: https://chromium-review.googlesource.com/727982
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510044}

TBR=dmazzoni@chromium.org,dtseng@chromium.org,mastiz@chromium.org

Change-Id: Iaa74032a25ec60545cf7be951b0dd0c7cf731afb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 776308,  773866 
Reviewed-on: https://chromium-review.googlesource.com/727901
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510051}
[modify] https://crrev.com/499282a044a1760a55e8dbe768415e05dbb0cd43/chrome/renderer/resources/extensions/automation_custom_bindings.js
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0ff2f1d7296167cd72e4ec9a3c52f68359ade04

commit c0ff2f1d7296167cd72e4ec9a3c52f68359ade04
Author: Mikel Astiz <mastiz@chromium.org>
Date: Thu Oct 19 12:53:41 2017

Revert "Reland: Fire focus if needed in automation api"

This reverts commit 0b78994873aeebee7ea93602a916a10facdd0848.

Reason for revert: breaks Linux ChromiumOS Tests.

Bug: 776308

Original change's description:
> Reland: Fire focus if needed in automation api
> 
> TBR=dtseng@chromium.org
> Bug:  773866 
> 
> Original change
> 
> Reviewed-on: https://chromium-review.googlesource.com/723606
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#509911}
> Change-Id: I74c39f7d8372b623a827dff89cc20b25f6485a2f
> Reviewed-on: https://chromium-review.googlesource.com/727122
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510006}

TBR=dmazzoni@chromium.org,dtseng@chromium.org

Change-Id: I9025ec011491530ec70cf0c1a0e33bdfec32c512
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  773866 
Reviewed-on: https://chromium-review.googlesource.com/728160
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510066}
[modify] https://crrev.com/c0ff2f1d7296167cd72e4ec9a3c52f68359ade04/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/c0ff2f1d7296167cd72e4ec9a3c52f68359ade04/chrome/renderer/resources/extensions/automation_custom_bindings.js
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66698953a9c3cafd55955f7422d1f86491668839

commit 66698953a9c3cafd55955f7422d1f86491668839
Author: David Tseng <dtseng@chromium.org>
Date: Thu Oct 19 17:57:01 2017

Reland2: Fire focus if needed in automation api

TBR=dtseng@chromium.org
Bug:  773866 

Original change

Reviewed-on: https://chromium-review.googlesource.com/723606
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509911}
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1a1be30f3e430f2417ab3ff4b9733de1b8004077
Reviewed-on: https://chromium-review.googlesource.com/728302
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510131}
[modify] https://crrev.com/66698953a9c3cafd55955f7422d1f86491668839/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
[modify] https://crrev.com/66698953a9c3cafd55955f7422d1f86491668839/chrome/renderer/resources/extensions/automation_custom_bindings.js

Comment 13 by dtseng@chromium.org, Oct 19 2017

Labels: Merge-Request-63
Owner: dtseng@chromium.org
Requesting merge for the latest reland (#2). Relands were due to test flakes, not due to the contents of the change.

Comment 14 by tapted@chromium.org, Oct 20 2017

Blockedon: 776308
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cb0482ff046272f0c3d0fba2808524ff2492017

commit 9cb0482ff046272f0c3d0fba2808524ff2492017
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Fri Oct 20 02:44:41 2017

Revert "Reland2: Fire focus if needed in automation api"

This reverts commit 66698953a9c3cafd55955f7422d1f86491668839.

Reason for revert: So sorry to do this! But that same test is failing consistently post this reland:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/24261
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_Chromium_OS_ASan_LSan_Tests__1_%2F24261%2F%2B%2Frecipes%2Fsteps%2Finteractive_ui_tests%2F0%2Flogs%2FTestAsNormalAndGuestUser__x2f_SpokenFeedbackTest.NavigateSystemTray__x2f_0%2F0

Original change's description:
> Reland2: Fire focus if needed in automation api
> 
> TBR=dtseng@chromium.org
> Bug:  773866 
> 
> Original change
> 
> Reviewed-on: https://chromium-review.googlesource.com/723606
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#509911}
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I1a1be30f3e430f2417ab3ff4b9733de1b8004077
> Reviewed-on: https://chromium-review.googlesource.com/728302
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510131}

TBR=dmazzoni@chromium.org,dtseng@chromium.org

Change-Id: Id0bc77906aee42b7449e72c71bc2c533ed7ddcb9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  773866 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/729720
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510305}
[modify] https://crrev.com/9cb0482ff046272f0c3d0fba2808524ff2492017/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
[modify] https://crrev.com/9cb0482ff046272f0c3d0fba2808524ff2492017/chrome/renderer/resources/extensions/automation_custom_bindings.js
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e77d96e161f842ea234fc13113d79d3c3779a4b

commit 0e77d96e161f842ea234fc13113d79d3c3779a4b
Author: Trent Apted <tapted@chromium.org>
Date: Fri Oct 20 03:16:37 2017

Disable CrOS TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateSystemTray/0 on Asan

Regressed most recently in r510131. Disabling the test since it's only
failing on Asan builds (and seemingly not with a memory error).

TBR=dtseng@chromium.org

Bug:  773866 , 776308
Change-Id: I786300a1924a1921dc8d796c9129acca25252ae4
Reviewed-on: https://chromium-review.googlesource.com/729608
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510316}
[modify] https://crrev.com/0e77d96e161f842ea234fc13113d79d3c3779a4b/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

Comment 17 by dtseng@chromium.org, Oct 20 2017

Labels: -Pri-2 M-63 Pri-1
NextAction: 2017-10-20
Status: assigned (was: Fixed)
Setting back to assigned since the merge to m63 is still pending and bumped pri.

Comment 18 by gkihumba@google.com, Oct 20 2017

Labels: -Merge-Request-63 Merge-Approved-63
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 20 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c40645f65d87fcce1cf71408f06dbfc43d85f4dc

commit c40645f65d87fcce1cf71408f06dbfc43d85f4dc
Author: David Tseng <dtseng@chromium.org>
Date: Fri Oct 20 22:55:50 2017

 codereview site.
Reland2: Fire focus if needed in automation api

TBR=dtseng@chromium.org
Bug:  773866 

Original change

Reviewed-on: https://chromium-review.googlesource.com/723606
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509911}
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1a1be30f3e430f2417ab3ff4b9733de1b8004077
Reviewed-on: https://chromium-review.googlesource.com/728302
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510131}
(cherry picked from commit 66698953a9c3cafd55955f7422d1f86491668839)




-UU-:**--F1  cl_descriptionqP6QN0   All L1     (Fundamental) ------------------
Beginning of buffer# This will be displayed on the codereview site.
[Merge to m63]: Fire focus if needed in automation api

Bug:  773866 

Original change

(cherry picked from commit 66698953a9c3cafd55955f7422d1f86491668839)

Reviewed-on: https://chromium-review.googlesource.com/723606
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/master@{#509911}
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1a1be30f3e430f2417ab3ff4b9733de1b8004077
Reviewed-on: https://chromium-review.googlesource.com/728302
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510131}
Reviewed-on: https://chromium-review.googlesource.com/731672
Cr-Commit-Position: refs/branch-heads/3239@{#129}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/c40645f65d87fcce1cf71408f06dbfc43d85f4dc/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
[modify] https://crrev.com/c40645f65d87fcce1cf71408f06dbfc43d85f4dc/chrome/renderer/resources/extensions/automation_custom_bindings.js
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac7d91f7709404b3d1bdcc477926aff95cc50edd

commit ac7d91f7709404b3d1bdcc477926aff95cc50edd
Author: David Tseng <dtseng@chromium.org>
Date: Thu Nov 16 21:58:08 2017

Revert "Revert "Reland2: Fire focus if needed in automation api""

This reverts commit 9cb0482ff046272f0c3d0fba2808524ff2492017.

Reason for revert: <INSERT REASONING HERE>
A subsequent change stops the failing test from being run on asan but went through after this revert. Seee bug 776308

Original change's description:
> Revert "Reland2: Fire focus if needed in automation api"
>
> This reverts commit 66698953a9c3cafd55955f7422d1f86491668839.
>
> Reason for revert: So sorry to do this! But that same test is failing consistently post this reland:
> https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/24261
> https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_Chromium_OS_ASan_LSan_Tests__1_%2F24261%2F%2B%2Frecipes%2Fsteps%2Finteractive_ui_tests%2F0%2Flogs%2FTestAsNormalAndGuestUser__x2f_SpokenFeedbackTest.NavigateSystemTray__x2f_0%2F0
>
> Original change's description:
> > Reland2: Fire focus if needed in automation api
> >
> > TBR=dtseng@chromium.org
> > Bug:  773866 
> >
> > Original change
> >
> > Reviewed-on: https://chromium-review.googlesource.com/723606
> > Commit-Queue: David Tseng <dtseng@chromium.org>
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Cr-Original-Commit-Position: refs/heads/master@{#509911}
> > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> > Change-Id: I1a1be30f3e430f2417ab3ff4b9733de1b8004077
> > Reviewed-on: https://chromium-review.googlesource.com/728302
> > Reviewed-by: David Tseng <dtseng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#510131}
>
> TBR=dmazzoni@chromium.org,dtseng@chromium.org
>
> Change-Id: Id0bc77906aee42b7449e72c71bc2c533ed7ddcb9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  773866 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Reviewed-on: https://chromium-review.googlesource.com/729720
> Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
> Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510305}

TBR=dmazzoni@chromium.org,dtseng@chromium.org,aboxhall@chromium.org
Bug: 776308,  773866 


# Not skipping CQ checks because original CL landed > 1 day ago.


Change-Id: Ia67d7681b56c6475f4824c82f434f0c1f0a820f8
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/775618
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517203}
[modify] https://crrev.com/ac7d91f7709404b3d1bdcc477926aff95cc50edd/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
[modify] https://crrev.com/ac7d91f7709404b3d1bdcc477926aff95cc50edd/chrome/renderer/resources/extensions/automation_custom_bindings.js

Comment 21 by dtseng@chromium.org, Feb 6 2018

Status: fixed (was: Assigned)
►

Sign in to add a comment