Paused + Cancelled download - design spec |
|||
Issue descriptionUpdated the paused and cancelled design spec Specs: https://drive.google.com/open?id=0BxMIIGI80eU-TDhkeTdwN0N3MFk States: https://drive.google.com/open?id=0BxMIIGI80eU-SUJWNlNuSTYxVVU
,
Oct 12 2017
Note the change in string ordering. The "Paused" should be first on the secondary line.
,
Oct 23 2017
Re: status text Yes, if we can lead with "Paused,..." on all platforms, that'd be preferred. LMK if another bug needs to be filed. Thanks! Lookin' great Sid!
,
Oct 23 2017
Thanks! It should be a separate bug, since the Mac UI just gets this text from the shared downloads code. I'm not sure if I'll be the right person to fix it (because there might be i18n gotchas), but I can take a look.
,
Oct 23 2017
Okay filed: crbug.com/777514 Also, do we not show "time remaining" in the line of text when in the paused state? My mocks include them but I should remove it if that's not what we do today. Your video in comment 3 doesn't show them.
,
Oct 24 2017
That's also in the cross-platform code, maybe file another bug?
,
Nov 4 2017
CL: https://chromium-review.googlesource.com/c/chromium/src/+/752262
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09a6a86a2f96795adb9e016535c536ea2ac5afb6 commit 09a6a86a2f96795adb9e016535c536ea2ac5afb6 Author: Sidney San Martín <sdy@chromium.org> Date: Mon Nov 06 14:15:08 2017 New animations and states for paused and canceled downloads. Bug: 773855 Change-Id: I33c879c42e41d4aaded3e7980ec96f1635a67275 Reviewed-on: https://chromium-review.googlesource.com/752262 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#514124} [modify] https://crrev.com/09a6a86a2f96795adb9e016535c536ea2ac5afb6/chrome/browser/ui/cocoa/download/md_download_item_progress_indicator.h [modify] https://crrev.com/09a6a86a2f96795adb9e016535c536ea2ac5afb6/chrome/browser/ui/cocoa/download/md_download_item_progress_indicator.mm [modify] https://crrev.com/09a6a86a2f96795adb9e016535c536ea2ac5afb6/chrome/browser/ui/cocoa/download/md_download_item_view.mm [modify] https://crrev.com/09a6a86a2f96795adb9e016535c536ea2ac5afb6/chrome/browser/ui/cocoa/md_util.h [modify] https://crrev.com/09a6a86a2f96795adb9e016535c536ea2ac5afb6/chrome/browser/ui/cocoa/md_util.mm
,
Nov 6 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bettes@chromium.org
, Oct 12 201799 KB
99 KB View Download