New issue
Advanced search Search tips

Issue 773854 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Browser=Exact Being Overridden By Directory

Project Member Reported by jonr...@chromium.org, Oct 11 2017

Issue description

I am seeing a failure when running with --browser=exact

The output directory for this run was /Work/src/out/cros

The command for running, call from the output folder: 

/usr/bin/python ../../testing/scripts/run_telemetry_as_googletest.py ../../tools/perf/run_telemetry_tests -v --jobs=1 --chrome-root ../../ telemetry.core.platform_unittest.PlatformScreenshotTest.testScreenshotSupported --browser=exact --browser-executable=./chrome --jobs=1 --isolated-script-test-output=../../../output.json --extra-browser-args="--use-gl=egl"

The error:


<type 'exceptions.AssertionError'> Please add cros to desktop_browser_finder.FindAllBrowserTypes <traceback object at 0x7fa329629758>

Traceback (most recent call last):
  <module> at /Work/src/third_party/catapult/telemetry/telemetry/testing/run_tests.py:303
    ret_code = RunTestsCommand.main()
  main at /Work/src/third_party/catapult/telemetry/telemetry/testing/run_tests.py:119
    cls.ProcessCommandLineArgs(parser, options, None)
  ProcessCommandLineArgs at /Work/src/third_party/catapult/telemetry/telemetry/testing/run_tests.py:98
    possible_browser = browser_finder.FindBrowser(args)
  Cacher at /Work/src/third_party/catapult/telemetry/telemetry/decorators.py:35
    cacher.__cache[key] = obj(*args, **kwargs)
  FindBrowser at /Work/src/third_party/catapult/telemetry/telemetry/internal/browser/browser_finder.py:69
    curr_browsers = finder.FindAllAvailableBrowsers(options, device)
  FindAllAvailableBrowsers at /Work/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py:214
    AddIfFound(browser_type, build_path, chromium_app_name, False)
  AddIfFound at /Work/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py:205
    content_shell, build_path, is_local_build=True))
  __init__ at /Work/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py:33
    browser_type)
AssertionError: Please add cros to desktop_browser_finder.FindAllBrowserTypes

Locals:
  browser_directory : '/Work/src/out/cros'
  browser_type      : 'cros'
  executable        : '/Work/src/out/cros/chrome'
  finder_options    : [('android_blacklist_file', None), ('browser_executable', './chrome'), ('browser_options', [('_browser_startup_timeout', 60), ('_extra_browser_args', set(['--use-gl=egl'])), ('block_modal_permission_prompts', True), ('browser_type', 'exact'), ('browser_user_agent_type', None), ('clear_sytem_cache_for_browser_and_profile_on_start', False), ('disable_background_networking', True), ('disable_component_extensions_with_background_pages', True), ('disable_default_apps', True), ('dont_override_profile', False), ... emote_platform_options.AndroidPlatformOptions object at 0x7fa329c00fd0>), ('repeat_count', 1), ('retry_limit', 0), ('run_disabled_tests', False), ('shard_index', 0), ('show_stdout', None), ('skip', []), ('start_xvfb', False), ('test_results_server', None), ('test_type', None), ('timing', False), ('top_level_dirs', ['/Work/src/third_party/catapult/telemetry']), ('total_shards', 1), ('verbosity', 1), ('webview_embedder_apk', None), ('write_full_results_to', '../../../output.json'), ('write_trace_to', None)] (truncated)
  flash_path        : None
  is_content_shell  : False
  is_local_build    : True
  target_os         : 'linux2'

It appears to be setting the browser type based on the directory.

This error goes away if I use a different binary. For example the target "test_chrome" for the executable doesn't trigger this.

 
Cc: perezju@chromium.org
Cc: achuith@chromium.org
Labels: -Pri-3 OS-Chrome Pri-2
Cc: -nednguyen@chromium.org nedngu...@google.com
Components: Test>Telemetry
Components: -Speed>Telemetry

Sign in to add a comment