New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773841 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Use trilinear filtering and Cache render surface in window switcher.

Project Member Reported by wutao@chromium.org, Oct 11 2017

Issue description

Similar to overview mode, we scale down the windows in window switcher.
To get better image quality, we can apply the trilinear filtering. At the same time we cache the render surface for good performance and reduced overdraw.
 

Comment 1 by wutao@chromium.org, Oct 13 2017

Cc: kaznacheev@chromium.org
Components: UI>Shell>WindowManager
Labels: M-63

Comment 2 by wutao@chromium.org, Oct 16 2017

The trilinear filtering results look good!
wc_Without_trilinear_filtering.png
439 KB View Download
wc_With_trilinear_filtering.png
466 KB View Download

Comment 3 by varkha@chromium.org, Oct 19 2017

Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c161162f9575030bf019c8d57b99f58bdc05c6d6

commit c161162f9575030bf019c8d57b99f58bdc05c6d6
Author: wutao <wutao@chromium.org>
Date: Fri Oct 20 18:16:59 2017

Use trilinear filtering and Cache render surface in window cycle view.

To get better image quality when we are scaling down windows in window
switcher, we can apply the trilinear filtering. At the same time we cache
the render surface for good performance and reduced overdraw.

Bug:773841
Test:Tested local

Screenshot:
without trilinear filtering:
https://screenshot.googleplex.com/ViYJWRZf8Wy

with trilinear filtering:

https: //screenshot.googleplex.com/N1TCJSKT3TS
Change-Id: Ide2d9899209a94fcae4781ca0bd4308e4b1c154c
Reviewed-on: https://chromium-review.googlesource.com/721633
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Valery Arkhangorodsky <varkha@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510495}
[modify] https://crrev.com/c161162f9575030bf019c8d57b99f58bdc05c6d6/ash/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/c161162f9575030bf019c8d57b99f58bdc05c6d6/ash/wm/window_cycle_list.cc
[modify] https://crrev.com/c161162f9575030bf019c8d57b99f58bdc05c6d6/ash/wm/window_mirror_view.cc
[modify] https://crrev.com/c161162f9575030bf019c8d57b99f58bdc05c6d6/ash/wm/window_mirror_view.h

Comment 5 by wutao@chromium.org, Oct 20 2017

Labels: Merge-Request-63 OS-Chrome

Comment 6 by gkihumba@google.com, Oct 20 2017

Labels: -Merge-Request-63 Merge-Approved-63
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 20 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a25d5cda88a2c0f90b5f38fd502a515b55e409e

commit 0a25d5cda88a2c0f90b5f38fd502a515b55e409e
Author: wutao <wutao@chromium.org>
Date: Fri Oct 20 22:32:52 2017

[Merge to M63] Use trilinear filtering and Cache render surface in window cycle view.

To get better image quality when we are scaling down windows in window
switcher, we can apply the trilinear filtering. At the same time we cache
the render surface for good performance and reduced overdraw.

TBR=reveman@chromium.org,varkha@chromium.org

Bug:773841
Test:Tested local

Screenshot:
without trilinear filtering:
https://screenshot.googleplex.com/ViYJWRZf8Wy

with trilinear filtering:
https: //screenshot.googleplex.com/N1TCJSKT3TS

Change-Id: Ide2d9899209a94fcae4781ca0bd4308e4b1c154c
Reviewed-on: https://chromium-review.googlesource.com/721633
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Valery Arkhangorodsky <varkha@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510495}(cherry picked from commit c161162f9575030bf019c8d57b99f58bdc05c6d6)
Reviewed-on: https://chromium-review.googlesource.com/730656
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#128}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/0a25d5cda88a2c0f90b5f38fd502a515b55e409e/ash/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/0a25d5cda88a2c0f90b5f38fd502a515b55e409e/ash/wm/window_cycle_list.cc
[modify] https://crrev.com/0a25d5cda88a2c0f90b5f38fd502a515b55e409e/ash/wm/window_mirror_view.cc
[modify] https://crrev.com/0a25d5cda88a2c0f90b5f38fd502a515b55e409e/ash/wm/window_mirror_view.h

Comment 8 by wutao@chromium.org, Mar 6 2018

Status: Fixed (was: Started)

Sign in to add a comment