New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773823 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue 771654



Sign in to add a comment

webgl2_conformance_gl_tests fail on Win7 NVIDIA

Project Member Reported by ynovikov@chromium.org, Oct 11 2017

Issue description

Lot of failures started when Jamie fixed this suite to actually run WebGL2 tests in https://chromium-review.googlesource.com/709460.
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Experimental%20Release%20%28NVIDIA%29/builds/32
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28NVIDIA%29/builds/31667

WebglConformance_conformance2_state_gl_object_get_calls
WebglConformance_conformance2_transform_feedback_transform_feedback
WebglConformance_conformance2_transform_feedback_two_unreferenced_varyings
WebglConformance_conformance2_transform_feedback_unwritten_output_defaults_to_zero
WebglConformance_deqp_functional_gles3_booleanstatequery
WebglConformance_deqp_functional_gles3_lifetime
WebglConformance_deqp_functional_gles3_negativeshaderapi
WebglConformance_deqp_functional_gles3_negativevertexarrayapi
WebglConformance_deqp_functional_gles3_shaderbuiltinvar
WebglConformance_deqp_functional_gles3_shadercommonfunction
WebglConformance_deqp_functional_gles3_shaderpackingfunction
WebglConformance_deqp_functional_gles3_shaderstatequery
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_interleaved_lines
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_interleaved_points
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_interleaved_triangles
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_separate_lines
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_separate_points
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_separate_triangles
WebglConformance_deqp_functional_gles3_transformfeedback_interpolation_centroid
WebglConformance_deqp_functional_gles3_transformfeedback_interpolation_flat
WebglConformance_deqp_functional_gles3_transformfeedback_interpolation_smooth
WebglConformance_deqp_functional_gles3_transformfeedback_point_size
WebglConformance_deqp_functional_gles3_transformfeedback_position
WebglConformance_deqp_functional_gles3_transformfeedback_random_interleaved_lines
WebglConformance_deqp_functional_gles3_transformfeedback_random_interleaved_points
WebglConformance_deqp_functional_gles3_transformfeedback_random_interleaved_triangles
WebglConformance_deqp_functional_gles3_transformfeedback_random_separate_lines
WebglConformance_deqp_functional_gles3_transformfeedback_random_separate_points
WebglConformance_deqp_functional_gles3_transformfeedback_random_separate_triangles

Going to disable them while this is investigated.
 
Cc: geoffl...@chromium.org jmad...@chromium.org
Components: Internals>GPU>ANGLE
Labels: Hotlist-PixelWrangler
Owner: ynovikov@chromium.org
Status: Assigned (was: Unconfirmed)
Thanks Yuly. Maybe Geoff you can take this once Yuly suppresses the failures?
Sure, what changed on the bots?
The generate_buildbot_json.py script was broken - the config was testing webgl 1 when it was supposed to be testing webgl 2.
Well, that's interesting.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cb59dfc1385ca28a051fc888b3391224ade7c18

commit 5cb59dfc1385ca28a051fc888b3391224ade7c18
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Thu Oct 12 01:19:23 2017

Skip failing webgl2_conformance_gl_tests on Win NVIDIA

WebglConformance_conformance2_state_gl_object_get_calls
WebglConformance_conformance2_transform_feedback_transform_feedback
WebglConformance_conformance2_transform_feedback_two_unreferenced_varyings
WebglConformance_conformance2_transform_feedback_unwritten_output_defaults_to_zero
WebglConformance_deqp_functional_gles3_booleanstatequery
WebglConformance_deqp_functional_gles3_lifetime
WebglConformance_deqp_functional_gles3_negativeshaderapi
WebglConformance_deqp_functional_gles3_negativevertexarrayapi
WebglConformance_deqp_functional_gles3_shaderbuiltinvar
WebglConformance_deqp_functional_gles3_shadercommonfunction
WebglConformance_deqp_functional_gles3_shaderpackingfunction
WebglConformance_deqp_functional_gles3_shaderstatequery
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_interleaved_lines
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_interleaved_points
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_interleaved_triangles
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_separate_lines
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_separate_points
WebglConformance_deqp_functional_gles3_transformfeedback_basic_types_separate_triangles
WebglConformance_deqp_functional_gles3_transformfeedback_interpolation_centroid
WebglConformance_deqp_functional_gles3_transformfeedback_interpolation_flat
WebglConformance_deqp_functional_gles3_transformfeedback_interpolation_smooth
WebglConformance_deqp_functional_gles3_transformfeedback_point_size
WebglConformance_deqp_functional_gles3_transformfeedback_position
WebglConformance_deqp_functional_gles3_transformfeedback_random_interleaved_lines
WebglConformance_deqp_functional_gles3_transformfeedback_random_interleaved_points
WebglConformance_deqp_functional_gles3_transformfeedback_random_interleaved_triangles
WebglConformance_deqp_functional_gles3_transformfeedback_random_separate_lines
WebglConformance_deqp_functional_gles3_transformfeedback_random_separate_points
WebglConformance_deqp_functional_gles3_transformfeedback_random_separate_triangles

BUG= 773823 
TBR=kbr@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I25fc0b178ef206b06fc5f29dd91b62c57754cc6c
Reviewed-on: https://chromium-review.googlesource.com/713764
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508201}
[modify] https://crrev.com/5cb59dfc1385ca28a051fc888b3391224ade7c18/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

It looks like they've passed consistently since that one failing build.  Maybe it was a flake?
The failed a bunch on the ANGLE try waterfall. The passing might be because of the driver upgrade combined with Yuly's CL to suppress the failures.
Somehow I've missed WebglConformance_deqp_functional_gles3_negativeshaderapi in my suppression. Going to add it.
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7158403f71440a3b0f7e009705560241b6bf9ad1

commit 7158403f71440a3b0f7e009705560241b6bf9ad1
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Thu Oct 12 21:48:14 2017

Skip one of webgl2_conformance_gl_tests on Win7 NVIDIA

WebglConformance_deqp_functional_gles3_negativeshaderapi
Missed it in https://chromium-review.googlesource.com/713764

BUG= 773823 
TBR=kbr@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7a5b7c0e1b70a8192deee9b82f2c63ea97883cab
Reviewed-on: https://chromium-review.googlesource.com/717146
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508485}
[modify] https://crrev.com/7158403f71440a3b0f7e009705560241b6bf9ad1/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Cc: kbr@chromium.org weiliangc@chromium.org
 Issue 774307  has been merged into this issue.
Owner: geoffl...@chromium.org
Not sure if you just want to close this as it seems to be passing on the new driver, or do you want to investigate a bit more, Geoff.
Anyway, we should lift the suppression when if all bots were upgraded.
Blockedon: 771654
The bot upgrade is complete. See  issue 771654 .
I don't think it's worth investigating right now since it's not used in production yet.  Agreed on lifting the supression, I can handle that.
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/935132b4244bf41aed4f6bab433259a5d85ae08e

commit 935132b4244bf41aed4f6bab433259a5d85ae08e
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Oct 19 20:25:18 2017

Remove Windows/NVIDIA/OpenGL WebGL2 conformance failure expectations.

These failures went away with the bot driver upgrade.

BUG= 773823 
TBR=zmo@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I01153c2213d10c70037217fb63549630b343ab61
Reviewed-on: https://chromium-review.googlesource.com/728324
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510186}
[modify] https://crrev.com/935132b4244bf41aed4f6bab433259a5d85ae08e/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 18 by kbr@chromium.org, Feb 8 2018

Status: Fixed (was: Assigned)
Calling this fixed.

Sign in to add a comment