New issue
Advanced search Search tips

Issue 773810 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Pixel does not align correctly in ref layout test

Project Member Reported by sunxd@chromium.org, Oct 11 2017

Issue description

We recently fixed a bug that solid color PictureLayerImpl ignores scale factors when append quads.

But the patch also brings up a possible pixel alignment bug: in layout test external/wpt/css/css-transforms-2/transform3d-perspective-008.html, the edge of the green div is different from reference, because when we apply IdealContentsScale 1.414 to 100x100 layer, we get enclosing bound 142x142, this is one pixel greater than the expected 141x141 bounds in reference.

We need to find out how to fix this.
 
Components: -Blink>Paint Blink>Compositing>Transform3D
Labels: Test-Layout PaintTeamTriaged-20171012 BugSource-Team
Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d044c564b237fbc80095a165d1f2c8009056ee4f

commit d044c564b237fbc80095a165d1f2c8009056ee4f
Author: Peter Mayo <petermayo@chromium.org>
Date: Wed Jul 11 18:35:46 2018

Re-enable passing WPT test transform3d-perspective-008.html

This test is passing at ToT.

Bug: 773810
Change-Id: Idbb463837ca1e969bd141126d04392dfbdcbda34
Reviewed-on: https://chromium-review.googlesource.com/1132538
Reviewed-by: Xianda Sun <sunxd@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574257}
[modify] https://crrev.com/d044c564b237fbc80095a165d1f2c8009056ee4f/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment