Issue metadata
Sign in to add a comment
|
flashrom: segfault on parrot when reading bios |
||||||||||||||||||||||
Issue descriptionafter this CL landed: https://chromium-review.googlesource.com/685608 flashrom now crashes on parrot: # flashrom -p host -r bios.bin Calibrating delay loop... OK. flashrom v0.9.9 : b17e9e4 : Sep 27 2017 19:58:03 UTC on Linux 3.8.11 (x86_64) flashrom v0.9.9 : b17e9e4 : Sep 27 2017 19:58:03 UTC on Linux 3.8.11 (x86_64) Segmentation fault (core dumped)
,
Oct 11 2017
Example of AU failing on parrot: https://bugs.chromium.org/p/chromium/issues/detail?id=772862#c28 This is a dev blocker, do you think fix can land today?
,
Oct 11 2017
I'm trying to locate a parrot i can remotely debug on.
,
Oct 11 2017
Hrmm. I just tried a recent build of coral's flashrom which has that CL on chromeos6-row2-rack3-host10.cros. There is no segfault. Is this parrot not representative of a failing one?
,
Oct 11 2017
Change is up for review: https://chromium-review.googlesource.com/#/c/chromiumos/third_party/flashrom/+/714396/
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/312b318dfb1d699ec8332abb5ba0e3764cfee121 commit 312b318dfb1d699ec8332abb5ba0e3764cfee121 Author: Aaron Durbin <adurbin@chromium.org> Date: Thu Oct 12 07:09:35 2017 cbtable: don't dereference memory that was previously unmapped The backing store for 'head' was being unmapped prior to dereferencing the variable. Don't do that, and calculate the new mapping size prior to unmapping the previous table. BUG= chromium:773801 BRANCH=none TEST=Ran on parrot and didn't segfault. Change-Id: Ic91345b8be50a73d498deba8269dc9e7112d12ee Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/714396 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/312b318dfb1d699ec8332abb5ba0e3764cfee121/cbtable.c
,
Oct 12 2017
,
Oct 12 2017
Parrot AUd successfully to Chrome OS 10025.0.0, 63.0.3236.0 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by gkihumba@google.com
, Oct 11 2017