404s contribute to Most Visited tiles on iOS |
||||
Issue descriptionContinuation of original report by mardini@, narrowed down here to the issue with 404s. Steps to reproduce: 1. Clear browsing history. 2. Visit a 404 page (e.g. httpbin.org/status/404) 3. Open NTP (a few times, until NTP tiles get updated). Expected result: Page returning 404 should not show up as MV tile. Actual result: Page shows up on on the NTP.
,
Oct 13 2017
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d0681551b79c909c1980a03343772fdef50a10f commit 9d0681551b79c909c1980a03343772fdef50a10f Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Oct 19 14:25:21 2017 Do not use 404s pages for Most Visited tiles The pages returning a 404 http status should not be displayed as Most Visited tiles on the NTP. This CL fixes it by checking the status code. Bug: 773792 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5381a36bc66b675acc4bc3a9b2fa703dc8d6f0ee Reviewed-on: https://chromium-review.googlesource.com/725294 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#510080} [modify] https://crrev.com/9d0681551b79c909c1980a03343772fdef50a10f/ios/chrome/browser/tabs/tab.mm
,
Oct 19 2017
,
Oct 25 2017
Verified on: App Version: 64.0.3248.0 canary Devices: iPhone 7, iPad Mini iOS Versions: 10.3.3, 11.0.2 Pages returning HTTP ERROR 404 are not displayed as Most visited Tiles on the NTP. Issue is fixed. Link for Video: https://drive.google.com/open?id=1dMCYP2IhTxjTaklxGyeC7rAQ-QyQ6Yar |
||||
►
Sign in to add a comment |
||||
Comment 1 by liaoyuke@chromium.org
, Oct 12 2017Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)