This is needed for voice search feature.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37d5fc566848db35eb790f1662e83055de89783b commit 37d5fc566848db35eb790f1662e83055de89783b Author: Biao She <bshe@chromium.org> Date: Thu Oct 19 20:21:52 2017 Add speech recognition API wrapper in VR This CL adds an invisible button which should trigger voice search. Note that the UI will change significantly. The main purpose of this CL is to add speech recognition API wrapper. Bug: 773767 Change-Id: If760a88cc950b231d3b2c14b94403afd8f23c56b Reviewed-on: https://chromium-review.googlesource.com/701174 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#510182} [modify] https://crrev.com/37d5fc566848db35eb790f1662e83055de89783b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/37d5fc566848db35eb790f1662e83055de89783b/chrome/browser/android/vr_shell/vr_gl_thread.cc [modify] https://crrev.com/37d5fc566848db35eb790f1662e83055de89783b/chrome/browser/android/vr_shell/vr_gl_thread.h [modify] https://crrev.com/37d5fc566848db35eb790f1662e83055de89783b/chrome/browser/android/vr_shell/vr_shell.cc [modify] https://crrev.com/37d5fc566848db35eb790f1662e83055de89783b/chrome/browser/android/vr_shell/vr_shell.h [modify] https://crrev.com/37d5fc566848db35eb790f1662e83055de89783b/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/37d5fc566848db35eb790f1662e83055de89783b/chrome/browser/vr/elements/ui_element_name.h [add] https://crrev.com/37d5fc566848db35eb790f1662e83055de89783b/chrome/browser/vr/speech_recognizer.cc [add] https://crrev.com/37d5fc566848db35eb790f1662e83055de89783b/chrome/browser/vr/speech_recognizer.h [add] https://crrev.com/37d5fc566848db35eb790f1662e83055de89783b/chrome/browser/vr/speech_recognizer_unittest.cc [modify] https://crrev.com/37d5fc566848db35eb790f1662e83055de89783b/chrome/browser/vr/test/mock_browser_interface.h [modify] https://crrev.com/37d5fc566848db35eb790f1662e83055de89783b/chrome/browser/vr/ui_browser_interface.h [modify] https://crrev.com/37d5fc566848db35eb790f1662e83055de89783b/chrome/browser/vr/ui_scene_manager.cc [modify] https://crrev.com/37d5fc566848db35eb790f1662e83055de89783b/chrome/browser/vr/ui_scene_manager.h [modify] https://crrev.com/37d5fc566848db35eb790f1662e83055de89783b/chrome/browser/vr/ui_scene_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04bba6df874896551becd06ebf101b7f0e2e0f4b commit 04bba6df874896551becd06ebf101b7f0e2e0f4b Author: Roberto Carrillo <robertocn@chromium.org> Date: Thu Oct 19 21:50:49 2017 Revert "Add speech recognition API wrapper in VR" This reverts commit 37d5fc566848db35eb790f1662e83055de89783b. Reason for revert: Speculative revert for SOLINK failure in https://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/46752 Original change's description: > Add speech recognition API wrapper in VR > > This CL adds an invisible button which should trigger voice search. > Note that the UI will change significantly. The main purpose of this > CL is to add speech recognition API wrapper. > > Bug: 773767 > Change-Id: If760a88cc950b231d3b2c14b94403afd8f23c56b > Reviewed-on: https://chromium-review.googlesource.com/701174 > Commit-Queue: Biao She <bshe@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#510182} TBR=vollick@chromium.org,bshe@chromium.org Change-Id: I2943d46e3d7d160852371a33f16e44ba1d62fbb6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773767 Reviewed-on: https://chromium-review.googlesource.com/729319 Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#510219} [modify] https://crrev.com/04bba6df874896551becd06ebf101b7f0e2e0f4b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/04bba6df874896551becd06ebf101b7f0e2e0f4b/chrome/browser/android/vr_shell/vr_gl_thread.cc [modify] https://crrev.com/04bba6df874896551becd06ebf101b7f0e2e0f4b/chrome/browser/android/vr_shell/vr_gl_thread.h [modify] https://crrev.com/04bba6df874896551becd06ebf101b7f0e2e0f4b/chrome/browser/android/vr_shell/vr_shell.cc [modify] https://crrev.com/04bba6df874896551becd06ebf101b7f0e2e0f4b/chrome/browser/android/vr_shell/vr_shell.h [modify] https://crrev.com/04bba6df874896551becd06ebf101b7f0e2e0f4b/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/04bba6df874896551becd06ebf101b7f0e2e0f4b/chrome/browser/vr/elements/ui_element_name.h [delete] https://crrev.com/2bdaf0af5e6ab06707931b0c1f8a79635219c024/chrome/browser/vr/speech_recognizer.cc [delete] https://crrev.com/2bdaf0af5e6ab06707931b0c1f8a79635219c024/chrome/browser/vr/speech_recognizer.h [delete] https://crrev.com/2bdaf0af5e6ab06707931b0c1f8a79635219c024/chrome/browser/vr/speech_recognizer_unittest.cc [modify] https://crrev.com/04bba6df874896551becd06ebf101b7f0e2e0f4b/chrome/browser/vr/test/mock_browser_interface.h [modify] https://crrev.com/04bba6df874896551becd06ebf101b7f0e2e0f4b/chrome/browser/vr/ui_browser_interface.h [modify] https://crrev.com/04bba6df874896551becd06ebf101b7f0e2e0f4b/chrome/browser/vr/ui_scene_manager.cc [modify] https://crrev.com/04bba6df874896551becd06ebf101b7f0e2e0f4b/chrome/browser/vr/ui_scene_manager.h [modify] https://crrev.com/04bba6df874896551becd06ebf101b7f0e2e0f4b/chrome/browser/vr/ui_scene_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a18d187d346ef25544fc350c6442c92a99c60e83 commit a18d187d346ef25544fc350c6442c92a99c60e83 Author: Alice Boxhall <aboxhall@chromium.org> Date: Fri Oct 20 00:27:42 2017 Revert "Add speech recognition API wrapper in VR" This reverts commit 37d5fc566848db35eb790f1662e83055de89783b. Reason for revert: It looks like this is causing a test failure for UiRendererTest::UiRendererSortingTest (https://cs.chromium.org/chromium/src/chrome/browser/vr/ui_renderer_unittest.cc?q=UiRendererSortingTest&sq=package:chromium&l=39) https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__1_%2F72602%2F%2B%2Frecipes%2Fsteps%2Fvr_common_unittests%2F0%2Flogs%2FSortingTests__x2f_UiRendererTest.UiRendererSortingTest__x2f_0%2F0 https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%281%29/builds/72602 Original change's description: > Add speech recognition API wrapper in VR > > This CL adds an invisible button which should trigger voice search. > Note that the UI will change significantly. The main purpose of this > CL is to add speech recognition API wrapper. > > Bug: 773767 > Change-Id: If760a88cc950b231d3b2c14b94403afd8f23c56b > Reviewed-on: https://chromium-review.googlesource.com/701174 > Commit-Queue: Biao She <bshe@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#510182} TBR=vollick@chromium.org,bshe@chromium.org Change-Id: I3131a869691bca49a0d97f3b3be658d27874bb98 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773767 Reviewed-on: https://chromium-review.googlesource.com/729799 Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#510264}
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03d022e8faf5192f3cd03cd3ed234bdccef51f84 commit 03d022e8faf5192f3cd03cd3ed234bdccef51f84 Author: Biao She <bshe@chromium.org> Date: Fri Oct 20 21:17:02 2017 Reland "Add speech recognition API wrapper in VR"" Previously, the CL failed with two errors: 1. vr_common_perftests stopped compile on Android_arm64 dbg builder 2. UiRendererTest::UiRendererSortingTest failure The original commit is: 37d5fc566848db35eb790f1662e83055de89783b " Add speech recognition API wrapper in VR This CL adds an invisible button which should trigger voice search. Note that the UI will change significantly. The main purpose of this CL is to add speech recognition API wrapper. Bug: 773767 Change-Id: If760a88cc950b231d3b2c14b94403afd8f23c56b Reviewed-on: https://chromium-review.googlesource.com/701174 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#510182} " Bug: 773767 Change-Id: I4bdcd465f686db9d668c5fe2b02d60e6051c2c82 Reviewed-on: https://chromium-review.googlesource.com/731026 Reviewed-by: Ian Vollick <vollick@chromium.org> Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#510562} [modify] https://crrev.com/03d022e8faf5192f3cd03cd3ed234bdccef51f84/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/03d022e8faf5192f3cd03cd3ed234bdccef51f84/chrome/browser/android/vr_shell/vr_gl_thread.cc [modify] https://crrev.com/03d022e8faf5192f3cd03cd3ed234bdccef51f84/chrome/browser/android/vr_shell/vr_gl_thread.h [modify] https://crrev.com/03d022e8faf5192f3cd03cd3ed234bdccef51f84/chrome/browser/android/vr_shell/vr_shell.cc [modify] https://crrev.com/03d022e8faf5192f3cd03cd3ed234bdccef51f84/chrome/browser/android/vr_shell/vr_shell.h [modify] https://crrev.com/03d022e8faf5192f3cd03cd3ed234bdccef51f84/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/03d022e8faf5192f3cd03cd3ed234bdccef51f84/chrome/browser/vr/elements/ui_element_name.h [add] https://crrev.com/03d022e8faf5192f3cd03cd3ed234bdccef51f84/chrome/browser/vr/speech_recognizer.cc [add] https://crrev.com/03d022e8faf5192f3cd03cd3ed234bdccef51f84/chrome/browser/vr/speech_recognizer.h [add] https://crrev.com/03d022e8faf5192f3cd03cd3ed234bdccef51f84/chrome/browser/vr/speech_recognizer_unittest.cc [modify] https://crrev.com/03d022e8faf5192f3cd03cd3ed234bdccef51f84/chrome/browser/vr/test/mock_browser_interface.h [modify] https://crrev.com/03d022e8faf5192f3cd03cd3ed234bdccef51f84/chrome/browser/vr/ui_browser_interface.h [modify] https://crrev.com/03d022e8faf5192f3cd03cd3ed234bdccef51f84/chrome/browser/vr/ui_renderer_unittest.cc [modify] https://crrev.com/03d022e8faf5192f3cd03cd3ed234bdccef51f84/chrome/browser/vr/ui_scene_manager.cc [modify] https://crrev.com/03d022e8faf5192f3cd03cd3ed234bdccef51f84/chrome/browser/vr/ui_scene_manager.h [modify] https://crrev.com/03d022e8faf5192f3cd03cd3ed234bdccef51f84/chrome/browser/vr/ui_scene_manager_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Oct 19 2017