New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773766 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 772207



Sign in to add a comment

Migrate to Metadata v2 and support PPD version restrictions

Project Member Reported by skau@chromium.org, Oct 11 2017

Issue description

We have a new metadata format which allows us to include restriction information for PPDs.  Switch to this format in chrome.
 
Owner: jycai@chromium.org
Status: Assigned (was: Available)
Tentatively assigning to jycai@ since we were chatting about this problem and he seemed interested in taking it on.

Note the change to solve this will almost certainly also resolve crbug/772207

Comment 2 by skau@chromium.org, Oct 11 2017

Sample manufacturers file with restrictions
http://www.gstatic.com/chromeos_printing/metadata_v2/Test_Entries-en.json

Comment 3 by skau@chromium.org, Nov 7 2017

Owner: luum@chromium.org
Implementation was started here: 
https://chromium-review.googlesource.com/c/chromium/src/+/744603

Comment 4 by skau@chromium.org, Nov 7 2017

Blocking: 772207
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fabb7687b791d9f9e707debd565f920b61d13bb

commit 8fabb7687b791d9f9e707debd565f920b61d13bb
Author: Luum Habtemariam <luum@chromium.org>
Date: Fri Dec 01 21:09:45 2017

Migrate to metadata v2 and support PPD Restrictions

Update the GetPrintersURL call to utilize metadata_v2. This allows for certain
restrictions to be placed on the model to determine whether or not the printer should be displayed

Bug:  chromium:773766 
Change-Id: Iaade00489a066340a095b3b07bbd853f13f8e35a
Reviewed-on: https://chromium-review.googlesource.com/797476
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521064}
[modify] https://crrev.com/8fabb7687b791d9f9e707debd565f920b61d13bb/chrome/browser/chromeos/printing/ppd_provider_factory.cc
[modify] https://crrev.com/8fabb7687b791d9f9e707debd565f920b61d13bb/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/8fabb7687b791d9f9e707debd565f920b61d13bb/chromeos/printing/ppd_provider.cc
[modify] https://crrev.com/8fabb7687b791d9f9e707debd565f920b61d13bb/chromeos/printing/ppd_provider.h
[modify] https://crrev.com/8fabb7687b791d9f9e707debd565f920b61d13bb/chromeos/printing/ppd_provider_unittest.cc

Comment 6 by skau@chromium.org, Dec 1 2017

Status: Started (was: Assigned)

Comment 7 by skau@chromium.org, Dec 5 2017

Is this fixed?

Comment 8 by skau@chromium.org, Dec 5 2017

FYI this landed in 65

~/chromium/src$ git find-releases 8fabb7687b
commit 8fabb7687b was:
  initially in 65.0.3283.0

Comment 9 by luum@chromium.org, Dec 8 2017

Status: Fixed (was: Started)
Fixed. Unsure on how to verify it.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d9a88d3ba0e13dc8a0b70996769b2a6c56e5b78

commit 6d9a88d3ba0e13dc8a0b70996769b2a6c56e5b78
Author: Luum Habtemariam <luum@chromium.org>
Date: Mon Dec 11 19:48:49 2017

Revert "Migrate to metadata v2 and support PPD Restrictions"

This reverts commit 8fabb7687b791d9f9e707debd565f920b61d13bb.

Reason for revert: Incomplete migration. Will try again soonish

Original change's description:
> Migrate to metadata v2 and support PPD Restrictions
>
> Update the GetPrintersURL call to utilize metadata_v2. This allows for certain
> restrictions to be placed on the model to determine whether or not the printer should be displayed
>
> Bug:  chromium:773766 
> Change-Id: Iaade00489a066340a095b3b07bbd853f13f8e35a
> Reviewed-on: https://chromium-review.googlesource.com/797476
> Commit-Queue: Luum Habtemariam <luum@chromium.org>
> Reviewed-by: Sean Kau <skau@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521064}

TBR=stevenjb@chromium.org,skau@chromium.org,justincarlson@chromium.org,luum@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:773766 
Change-Id: Ia17119151bf2d88951589b47e2ea0c1c38796cd2
Reviewed-on: https://chromium-review.googlesource.com/820291
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523177}
[modify] https://crrev.com/6d9a88d3ba0e13dc8a0b70996769b2a6c56e5b78/chrome/browser/chromeos/printing/ppd_provider_factory.cc
[modify] https://crrev.com/6d9a88d3ba0e13dc8a0b70996769b2a6c56e5b78/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/6d9a88d3ba0e13dc8a0b70996769b2a6c56e5b78/chromeos/printing/ppd_provider.cc
[modify] https://crrev.com/6d9a88d3ba0e13dc8a0b70996769b2a6c56e5b78/chromeos/printing/ppd_provider.h
[modify] https://crrev.com/6d9a88d3ba0e13dc8a0b70996769b2a6c56e5b78/chromeos/printing/ppd_provider_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67e8adb8266847cf4f50a9c4b72f5135d1788e8d

commit 67e8adb8266847cf4f50a9c4b72f5135d1788e8d
Author: Luum Habtemariam <luum@chromium.org>
Date: Fri Jan 05 00:01:21 2018

Migrate to metadata v2 and support PPD Restrictions

Migrate printer metadata to v2. This also allows for certain
restrictions to be placed on the model to determine whether or not the
printer should be displayed.

This change also reflects the metadata v2 change of lowercasing all
effective_make_and_model strings.

BUG= chromium:772207 , chromium:773766 

Change-Id: I687c90b240df511ddffbf8a349ac2d1503321902
Reviewed-on: https://chromium-review.googlesource.com/831112
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527156}
[modify] https://crrev.com/67e8adb8266847cf4f50a9c4b72f5135d1788e8d/chrome/browser/chromeos/printing/ppd_provider_factory.cc
[modify] https://crrev.com/67e8adb8266847cf4f50a9c4b72f5135d1788e8d/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/67e8adb8266847cf4f50a9c4b72f5135d1788e8d/chromeos/printing/ppd_provider.cc
[modify] https://crrev.com/67e8adb8266847cf4f50a9c4b72f5135d1788e8d/chromeos/printing/ppd_provider.h
[modify] https://crrev.com/67e8adb8266847cf4f50a9c4b72f5135d1788e8d/chromeos/printing/ppd_provider_unittest.cc

Sign in to add a comment