New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 773758 link

Starred by 1 user
Status: Fixed
Owner:
mdjones@chromium.org
Closed: Oct 2017
Cc:
█ danielpark@chromium.org
tedc...@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Android infobar added event triggered before init complete

Project Member Reported by mdjones@chromium.org, Oct 11 2017 
On Android, the InfoBarContainerObserver.onAddInfoBar event is triggered before the native infobar is set on the java object. As a result, any user trying to collect information from the native infobar in this event will get bad information.

The change that needs to be made appears to be in infobar_container_android.cc. The native infobar is set on the java side immediately after the call that triggers the event. Switching these two should fix the problem.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c931aa19f726d715e68c4691498d8bbe14c9d156

commit c931aa19f726d715e68c4691498d8bbe14c9d156
Author: Matthew Jones <mdjones@chromium.org>
Date: Wed Oct 11 20:49:10 2017

Finish infobar init before triggering onAddInfoBar event

The java infobar should be passed a handle to native before the
relevant event is triggered. This change switches two calls in native
so this is now the case.

BUG= 773758 

Change-Id: Icb6ffe5a15aca9268efe1a1e4ab80044ce5250bc
Reviewed-on: https://chromium-review.googlesource.com/713698
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508102}
[modify] https://crrev.com/c931aa19f726d715e68c4691498d8bbe14c9d156/chrome/browser/ui/android/infobars/infobar_container_android.cc

Comment 2 by mdjones@chromium.org, Oct 11 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment