New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773757 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 609317



Sign in to add a comment

Unify ui::GpuClient and content::GpuClient

Project Member Reported by sadrul@chromium.org, Oct 11 2017

Issue description

mojom.Gpu [1] is implemented by ui::GpuClient in the mus window-server [2], and content::GpuClient in the chrome browser [3]. They should be merged into a single implementation, which should live in components/viz/host/.

[1] https://cs.chromium.org/chromium/src/services/ui/public/interfaces/gpu.mojom?l=15
[2] https://cs.chromium.org/chromium/src/services/ui/ws/gpu_client.h?l=31
[3] https://cs.chromium.org/chromium/src/content/browser/gpu/gpu_client.h?l=16
 

Comment 1 by sadrul@chromium.org, Oct 11 2017

Blocking: 609317

Comment 2 by sadrul@chromium.org, Oct 12 2017

Cc: kylec...@chromium.org
Cc: fsam...@chromium.org
Labels: Proj-Mash-MultiProcess
Labels: -Proj-Mustash-Mus-GPU
Cleaning up old Proj-Mustash labels.
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c97b6d0226cf453b3c30fd16b8d153771d9824ef

commit c97b6d0226cf453b3c30fd16b8d153771d9824ef
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Mon Oct 08 23:08:18 2018

Use viz::GpuClient in OopAsh

This CL removes ws::gpu_host::GpuClient and replaces its usage with
viz::GpuClient.

BUG= 773757 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Idecc2cbfc5390879f4490dade85d64840f77d126
Reviewed-on: https://chromium-review.googlesource.com/c/1240636
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597720}
[modify] https://crrev.com/c97b6d0226cf453b3c30fd16b8d153771d9824ef/components/viz/host/gpu_client.cc
[modify] https://crrev.com/c97b6d0226cf453b3c30fd16b8d153771d9824ef/components/viz/host/gpu_client.h
[modify] https://crrev.com/c97b6d0226cf453b3c30fd16b8d153771d9824ef/services/ws/gpu_host/BUILD.gn
[modify] https://crrev.com/c97b6d0226cf453b3c30fd16b8d153771d9824ef/services/ws/gpu_host/DEPS
[delete] https://crrev.com/5f45e7b3e941a031d2e3e3d59c9874ba88911657/services/ws/gpu_host/gpu_client.cc
[delete] https://crrev.com/5f45e7b3e941a031d2e3e3d59c9874ba88911657/services/ws/gpu_host/gpu_client.h
[modify] https://crrev.com/c97b6d0226cf453b3c30fd16b8d153771d9824ef/services/ws/gpu_host/gpu_host.cc
[modify] https://crrev.com/c97b6d0226cf453b3c30fd16b8d153771d9824ef/services/ws/gpu_host/gpu_host.h
[add] https://crrev.com/c97b6d0226cf453b3c30fd16b8d153771d9824ef/services/ws/gpu_host/gpu_host_test_api.cc
[add] https://crrev.com/c97b6d0226cf453b3c30fd16b8d153771d9824ef/services/ws/gpu_host/gpu_host_test_api.h
[modify] https://crrev.com/c97b6d0226cf453b3c30fd16b8d153771d9824ef/services/ws/gpu_host/gpu_host_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment