Issue metadata
Sign in to add a comment
|
ShelfAppBrowserTest.OverflowBubble failing flakily on linux_chromium_chromeos_rel_ng tryserver |
||||||||||||||||||||||
Issue descriptionSee this tryserver: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng?numbuilds=200 A few recent instances: https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_chromeos_rel_ng/526490 https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_chromeos_rel_ng/526454 https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_chromeos_rel_ng/526453 https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_chromeos_rel_ng/526441 Log excerpt: [7586:7586:1011/090511.961881:FATAL:shelf_view.cc(776)] Check failed: last_visible_index_ < view_model_->view_size() (17 vs. 17) #0 0x000003a3f01c base::debug::StackTrace::StackTrace() #1 0x000003a58f0c logging::LogMessage::~LogMessage() #2 0x0000064703b5 ash::ShelfView::UpdateAllButtonsVisibilityInOverflowMode() #3 0x00000646fb52 ash::ShelfView::CalculateIdealBounds() #4 0x00000646edf4 ash::ShelfView::AnimateToIdealBounds() #5 0x00000647184c ash::ShelfView::ShelfItemRemoved() #6 0x00000658d377 ash::ShelfModel::RemoveItemAt() #7 0x00000646695b ash::ShelfController::RemoveShelfItem() #8 0x000002c7a00c ash::mojom::ShelfControllerStubDispatch::Accept() #9 0x000004f7db2b mojo::InterfaceEndpointClient::HandleValidatedMessage() #10 0x000004f7d716 mojo::FilterChain::Accept() #11 0x000004f7ee95 mojo::InterfaceEndpointClient::HandleIncomingMessage() #12 0x000004f87f74 mojo::internal::MultiplexRouter::ProcessIncomingMessage() #13 0x000004f874c4 mojo::internal::MultiplexRouter::Accept() #14 0x000004f7d716 mojo::FilterChain::Accept() ... This is causing valid CLs to be kicked out of the commit queue. Could someone please triage this? Thanks.
,
Oct 11 2017
I was able to locally repro a different failure in the same test within a few runs: ../../chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc:2332: Failure Value of: shelf_->shelf_widget()->IsShowingOverflowBubble() Actual: true Expected: false It may help to use the new ChromeLauncherController::FlushForTesting that I added. But perhaps it would make more sense to move this test to an ash-side unit test. (nothing here is really chrome-specific, except the need to use IPC access points)
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fc13eb13ac37d66e7df0819e28ee006956029f4 commit 8fc13eb13ac37d66e7df0819e28ee006956029f4 Author: Mike Wasserman <msw@chromium.org> Date: Thu Oct 12 01:22:50 2017 ash: Convert flaky overflow browser test to an ash unit test. Simplify this test that really just concerns ash-side behavior. Bug: 773748 Change-Id: I5a6ce6db015357cb7a5b1c5e87dea27dc98cf348 Reviewed-on: https://chromium-review.googlesource.com/714380 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#508207} [modify] https://crrev.com/8fc13eb13ac37d66e7df0819e28ee006956029f4/ash/shelf/shelf_view_unittest.cc [modify] https://crrev.com/8fc13eb13ac37d66e7df0819e28ee006956029f4/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
,
Oct 12 2017
The new test has passed one at least one trybot run... calling this fixed.
,
Jan 22 2018
,
Jan 23 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jamescook@chromium.org
, Oct 11 2017Status: Assigned (was: Untriaged)