New issue
Advanced search Search tips

Issue 773741 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 13
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make Canvas always accelerated if possible

Project Member Reported by fs...@chromium.org, Oct 11 2017

Issue description

We want to remove the size threshold for accelerated canvas.

We will slowly reduce the threshold per release.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c15174fe589f664d882bdf37d6f4706a4622d69d

commit c15174fe589f664d882bdf37d6f4706a4622d69d
Author: Fernando Serboncini <fserb@chromium.org>
Date: Thu Oct 12 16:00:50 2017

Reduce minimum accelerated 2D canvas threshold to 129x128

Bug:  773741 
Change-Id: I38d68894e72289ffa81af21c56d8fc09d51533b2
Reviewed-on: https://chromium-review.googlesource.com/713555
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508360}
[modify] https://crrev.com/c15174fe589f664d882bdf37d6f4706a4622d69d/third_party/WebKit/Source/core/frame/Settings.json5

Comment 2 by fs...@chromium.org, Oct 18 2017

Previous land was for M63. Sending next one for M64.
Block this bug, if we find any errors.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10d9c9234a10847624e8a10c81749f476034380d

commit 10d9c9234a10847624e8a10c81749f476034380d
Author: Fernando Serboncini <fserb@chromium.org>
Date: Fri Oct 20 19:02:51 2017

Reduce minimum accelerated 2D canvas threshold to 65x64

Bug:  773741 
Change-Id: I462d389bfa3c72e0f0fd63f8996ea57ed8b63e0f
Reviewed-on: https://chromium-review.googlesource.com/726244
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510508}
[modify] https://crrev.com/10d9c9234a10847624e8a10c81749f476034380d/third_party/WebKit/Source/core/frame/Settings.json5

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77fe9e094ae8e095ab694f0182069789df2d2afc

commit 77fe9e094ae8e095ab694f0182069789df2d2afc
Author: Justin Novosad <junov@chromium.org>
Date: Wed Oct 25 19:04:37 2017

Revert "Reduce minimum accelerated 2D canvas threshold to 65x64"

This reverts commit 10d9c9234a10847624e8a10c81749f476034380d.

Reason for revert: This experiment should not go further without a finch trial.  We don't even have any data to consider from the previous iteration.

Original change's description:
> Reduce minimum accelerated 2D canvas threshold to 65x64
> 
> Bug:  773741 
> Change-Id: I462d389bfa3c72e0f0fd63f8996ea57ed8b63e0f
> Reviewed-on: https://chromium-review.googlesource.com/726244
> Reviewed-by: Justin Novosad <junov@chromium.org>
> Commit-Queue: Fernando Serboncini <fserb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510508}

TBR=junov@chromium.org,fserb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  773741 
Change-Id: Ic3ff30fe0f346c15de20ee44197db8ac8e1f12ae
Reviewed-on: https://chromium-review.googlesource.com/738309
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511544}
[modify] https://crrev.com/77fe9e094ae8e095ab694f0182069789df2d2afc/third_party/WebKit/Source/core/frame/Settings.json5

Status: Assigned (was: Started)
Cc: -junov@chromium.org
Status: Fixed (was: Assigned)
We reduced a bit the threshold, but we are doing a bigger project around performance. Closing this as fixed.

Sign in to add a comment