New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773721 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

platform_ToolchainOptions failure for reef-uni/sand

Project Member Reported by dchan@chromium.org, Oct 11 2017

Issue description

see https://cros-goldeneye.corp.google.com/chromeos/console/viewBuild?version=10019.0.0&channel=dev&type=release

under reef-uni, model sand 1/45 failure
vs reef/sand has 45 passes.

Here are the failed autotest result output https://uberchromeos-server38.corp.google.com/tko/retrieve_logs.cgi?job=/results/147944597-chromeos-test/chromeos2-row3-rack4-host9
under debug/client0.INFO shows the following log outpu:


10/10 06:48:06.427 INFO |      base_sysinfo:0393| ChromeOS BOARD = reef-uni_1.1GHz_4GB
10/10 06:51:42.744 ERROR|platform_Toolchain:0305| Test Executable Stack 1 failures
FAILED:
/usr/sbin/mosys



10/10 06:51:42.829 WARNI|              test:0612| The test failed with the following exception
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 606, in _exec
    _call_test_function(self.execute, *p_args, **p_dargs)
  File "/usr/local/autotest/common_lib/test.py", line 806, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/common_lib/test.py", line 470, in execute
    dargs)
  File "/usr/local/autotest/common_lib/test.py", line 347, in _call_run_once_with_retry
    postprocess_profiled_run, args, dargs)
  File "/usr/local/autotest/common_lib/test.py", line 380, in _call_run_once
    self.run_once(*args, **dargs)
  File "/usr/local/autotest/tests/platform_ToolchainOptions/platform_ToolchainOptions.py", line 308, in run_once
    raise error.TestFail(fail_summary_msg)
TestFail: Test Executable Stack 1 failures

 

Comment 1 by dchan@chromium.org, Oct 12 2017

Cc: shapiroc@google.com
Owner: sjg@chromium.org
Assuming this is related to recent mosys changes.

Comment 4 by sjg@chromium.org, Oct 17 2017

There is a new section in mosys:

  [16] .dtb.init.rodata  PROGBITS         000000000006ec50  0006ec50
       0000000000001220  0000000000000000   A       0     0     16

https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/site_tests/platform_ToolchainOptions/platform_ToolchainOptions.py?type=cs&q=platform_toolchainoptions&sq=package:%5Echromeos_(internal%7Cpublic)$&l=116

It is not obvious which test failed from any of the logs. What I am missing?

Comment 5 by sjg@chromium.org, Nov 4 2017

Labels: Unibuild

Comment 6 by sjg@chromium.org, Nov 6 2017

Owner: la...@chromium.org
Here's another one

Comment 8 by la...@chromium.org, Nov 7 2017

This was introduced in crrev.com/403f374a623e9da62f612f5af28565f73b5b98bb.

Comment 9 by ketakid@google.com, Nov 8 2017

Can we revert that CL and unblock these devices?

Comment 10 by sjg@chromium.org, Nov 8 2017

Status: Started (was: Untriaged)
That would break coral though. Lann has a fix here:

https://chromium-review.googlesource.com/c/chromiumos/platform/mosys/+/756886
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mosys/+/4a6f78bf288e2e8ba8cad8279233cae6048910b2

commit 4a6f78bf288e2e8ba8cad8279233cae6048910b2
Author: Lann Martin <lannm@chromium.org>
Date: Wed Nov 08 11:12:28 2017

Fix executable stack segments

Something about the config.dtb.o object seems to have confused ld into
thinking it needed an executable stack. Adding -znoexecstack to LDFLAGS
convinces it otherwise.

BUG= 773721 
TEST=readelf -lW mosys; see the stack no longer has the exec (E) bit set

Change-Id: Idaef8d54bc8b14e90279f47ad21cdf12355992be
Reviewed-on: https://chromium-review.googlesource.com/756886
Commit-Ready: Lann Martin <lannm@chromium.org>
Tested-by: Lann Martin <lannm@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/4a6f78bf288e2e8ba8cad8279233cae6048910b2/lib/cros_config/Makefile

Status: Fixed (was: Started)

Sign in to add a comment