New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773719 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 3
Type: Bug

Blocked on:
issue 690467



Sign in to add a comment

Clean up after ddljson launch

Project Member Reported by treib@chromium.org, Oct 11 2017

Issue description

After the ddljson API has launched to stable (M62), we can get rid of the code that handles the old newtab_mobile API.
 
Labels: zine-triaged

Comment 2 by treib@chromium.org, Oct 12 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fc99e1fb1fc7c397704413d239632f1c9298b17

commit 5fc99e1fb1fc7c397704413d239632f1c9298b17
Author: Marc Treib <treib@chromium.org>
Date: Wed Nov 08 12:19:18 2017

Cleanup after features::kUseDdljsonApi launch

This feature was launched in M62. Time to get rid of the previous code.
This CL removes the feature itself and the "disabled" code path.
Some about:flags entries are still useful for testing, so those are kept
and converted from using feature params to using a command line switch.

Bug:  773719 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If8ca41f7857f28561e070138f61e90ebd8b982fe
Reviewed-on: https://chromium-review.googlesource.com/716257
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514806}
[modify] https://crrev.com/5fc99e1fb1fc7c397704413d239632f1c9298b17/chrome/browser/about_flags.cc
[modify] https://crrev.com/5fc99e1fb1fc7c397704413d239632f1c9298b17/components/search_provider_logos/features.cc
[modify] https://crrev.com/5fc99e1fb1fc7c397704413d239632f1c9298b17/components/search_provider_logos/features.h
[modify] https://crrev.com/5fc99e1fb1fc7c397704413d239632f1c9298b17/components/search_provider_logos/google_logo_api.cc
[modify] https://crrev.com/5fc99e1fb1fc7c397704413d239632f1c9298b17/components/search_provider_logos/google_logo_api.h
[modify] https://crrev.com/5fc99e1fb1fc7c397704413d239632f1c9298b17/components/search_provider_logos/google_logo_api_unittest.cc
[modify] https://crrev.com/5fc99e1fb1fc7c397704413d239632f1c9298b17/components/search_provider_logos/logo_service_impl.cc
[modify] https://crrev.com/5fc99e1fb1fc7c397704413d239632f1c9298b17/components/search_provider_logos/logo_service_impl_unittest.cc
[modify] https://crrev.com/5fc99e1fb1fc7c397704413d239632f1c9298b17/components/search_provider_logos/logo_tracker.cc
[modify] https://crrev.com/5fc99e1fb1fc7c397704413d239632f1c9298b17/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/5fc99e1fb1fc7c397704413d239632f1c9298b17/tools/metrics/histograms/enums.xml

Comment 4 by treib@chromium.org, Nov 13 2017

Status: Fixed (was: Started)

Sign in to add a comment