Issue metadata
Sign in to add a comment
|
Wrong word order of infobar announcement i18n |
||||||||||||||||||||||||
Issue descriptionChrome Version: M63 OS: Android What steps will reproduce the problem? (1) Enable TalkBack (2) Use a locale not in SVO or SOV word order (3) Trigger an infobar with a title, like PreviewsInfobar. What is the expected result? Announcement of the infobar should be correct in grammar. What happens instead? It is still in SVO or SOV order. Reference: https://en.wikipedia.org/wiki/Word_order We use string concatenation, which would not work if Subject is not first. title + mContext.getString(R.string.bottom_bar_screen_position);
,
Oct 13 2017
This issue seems to be out of TE-scope. Hence, adding label TE-NeedsTriageHelp for further investigation from dev team. Thanks!!
,
Oct 13 2017
Shimi, do you have ideas about how to proceed?
,
Oct 18 2017
One way to fix this is to make the announcement two sentences, like what Snackbar does: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java?type=cs&q=accessibility+file:%5Esrc/chrome/android/java/src/org/chromium/chrome/browser/snackbar/+package:%5Echromium$&l=208 Do we need to regulate whether InfoBar#getAccessibilityMessage should return a noun or a sentence? TranslateCompactInfoBar returns "Translate", a noun. ReaderModeInfoBar returns "Make page mobile-friendly", an imperative sentence. For non-compact InfoBars, the main text in R.id.infobar_message is used, so could be either.
,
Oct 30 2017
Could you help me understand why the string is concatenated in the first place, instead of being written as a single message?
,
Oct 30 2017
+mdjones@, the infobar owner It looks like Snackbar.java is using string concatenation, which is fine if two separate sentences are being read (as wynchen@ noted in #4). The infobar/snackbar description being a full sentence followed by "Options available near bottom of the screen." was probably the intention when content descriptions for these widgets were implemented. Mini-infobars, like the translate infobar, are relatively new.
,
Oct 31 2017
We shouldn't ever use concatenation for accessibility text but have never discussed alternatives. I suppose the alternative would be to include that text with each infobar's translation individually. Maybe we could announce the "options at bottom" once for the container and proceed with every other bottom item.
,
Sep 21
Please open this bug again if you are still seeing this issue. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ligim...@chromium.org
, Oct 11 2017