New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773713 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue v8:6919

Blocking:
issue v8:6693



Sign in to add a comment

Implement `import.meta.url`

Project Member Reported by gsat...@chromium.org, Oct 11 2017

Issue description

Blocking: v8:6693

Comment 2 by kouhei@chromium.org, Oct 11 2017

Owner: hirosh...@chromium.org
Status: Assigned (was: Available)
hiroshige@ and/or kouhei@ will implement import.meta.url, aiming for Q4.
Status: Started (was: Assigned)
Blockedon: v8:6919
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15c2eb99486263f07f2bb11b423e971c5f2d90e4

commit 15c2eb99486263f07f2bb11b423e971c5f2d90e4
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Oct 20 04:57:05 2017

[import.meta.url] Add --enable-module-scripts-import-meta-url flag

The flag is disabled by default.
Implementation will be added in
https://chromium-review.googlesource.com/c/chromium/src/+/726525.

When the flag is enabled, --harmony-import-meta V8 flag is also added.

Bug:  773713 
Change-Id: Ib78a2f1b25d488be7aa3bda0138c6e09d79ead7a
Reviewed-on: https://chromium-review.googlesource.com/727179
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510343}
[modify] https://crrev.com/15c2eb99486263f07f2bb11b423e971c5f2d90e4/chrome/browser/about_flags.cc
[modify] https://crrev.com/15c2eb99486263f07f2bb11b423e971c5f2d90e4/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/15c2eb99486263f07f2bb11b423e971c5f2d90e4/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/15c2eb99486263f07f2bb11b423e971c5f2d90e4/content/child/runtime_features.cc
[modify] https://crrev.com/15c2eb99486263f07f2bb11b423e971c5f2d90e4/content/public/common/content_features.cc
[modify] https://crrev.com/15c2eb99486263f07f2bb11b423e971c5f2d90e4/content/public/common/content_features.h
[modify] https://crrev.com/15c2eb99486263f07f2bb11b423e971c5f2d90e4/content/renderer/render_process_impl.cc
[modify] https://crrev.com/15c2eb99486263f07f2bb11b423e971c5f2d90e4/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/15c2eb99486263f07f2bb11b423e971c5f2d90e4/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/15c2eb99486263f07f2bb11b423e971c5f2d90e4/third_party/WebKit/public/platform/WebRuntimeFeatures.h
[modify] https://crrev.com/15c2eb99486263f07f2bb11b423e971c5f2d90e4/tools/metrics/histograms/enums.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 20 2017

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03ab3c4833605018d8bd5c2cd5efb94434450407

commit 03ab3c4833605018d8bd5c2cd5efb94434450407
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Tue Oct 24 01:23:39 2017

[import.meta.url] Implement import.meta.url behind flag (Blink-side)

This CL implements
https://html.spec.whatwg.org/#hostgetimportmetaproperties
as HostGetImportMetaProperties() in V8Initializer.cpp and Modulator,
and thus enables import.meta.url behind the flag added in
https://chromium-review.googlesource.com/c/chromium/src/+/727179.

This CL also adds a layout test, and sets up virtual test for that.

Bug:  773713 
Change-Id: I1d28123f803095535ed9a0208587e1dd873376cb
Reviewed-on: https://chromium-review.googlesource.com/726525
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510988}
[modify] https://crrev.com/03ab3c4833605018d8bd5c2cd5efb94434450407/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/03ab3c4833605018d8bd5c2cd5efb94434450407/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/03ab3c4833605018d8bd5c2cd5efb94434450407/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-dependent.js
[add] https://crrev.com/03ab3c4833605018d8bd5c2cd5efb94434450407/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-root.js
[add] https://crrev.com/03ab3c4833605018d8bd5c2cd5efb94434450407/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-url.html
[add] https://crrev.com/03ab3c4833605018d8bd5c2cd5efb94434450407/third_party/WebKit/LayoutTests/virtual/import-meta-url/external/wpt/html/semantics/scripting-1/the-script-element/module/import-meta/README.txt
[modify] https://crrev.com/03ab3c4833605018d8bd5c2cd5efb94434450407/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
[modify] https://crrev.com/03ab3c4833605018d8bd5c2cd5efb94434450407/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/03ab3c4833605018d8bd5c2cd5efb94434450407/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/03ab3c4833605018d8bd5c2cd5efb94434450407/third_party/WebKit/Source/core/dom/Modulator.h
[modify] https://crrev.com/03ab3c4833605018d8bd5c2cd5efb94434450407/third_party/WebKit/Source/core/dom/ModulatorImplBase.cpp
[modify] https://crrev.com/03ab3c4833605018d8bd5c2cd5efb94434450407/third_party/WebKit/Source/core/dom/ModulatorImplBase.h
[add] https://crrev.com/03ab3c4833605018d8bd5c2cd5efb94434450407/third_party/WebKit/Source/core/dom/ModuleImportMeta.h
[modify] https://crrev.com/03ab3c4833605018d8bd5c2cd5efb94434450407/third_party/WebKit/Source/core/testing/DummyModulator.cpp
[modify] https://crrev.com/03ab3c4833605018d8bd5c2cd5efb94434450407/third_party/WebKit/Source/core/testing/DummyModulator.h

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3031e55cb00232d14ecce2302345c97085f85fc9

commit 3031e55cb00232d14ecce2302345c97085f85fc9
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Oct 27 01:18:08 2017

[import.meta.url] Enable import.meta.url by default

Intent-to-ship thread w/ 3 lgtms:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Hq3cVNto74c/x7tNhmZUBQAJ

Bug:  773713 
Change-Id: Iba1d2e287264c27451af5a823891004882c95b41
Reviewed-on: https://chromium-review.googlesource.com/740089
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512050}
[modify] https://crrev.com/3031e55cb00232d14ecce2302345c97085f85fc9/content/public/common/content_features.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ff0a9383fb2be7c694408a6e30cf5b3aade8292

commit 2ff0a9383fb2be7c694408a6e30cf5b3aade8292
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Fri Dec 22 07:48:42 2017

[ES6 modules] mark import.meta wpt as pass

import.meta has already shipped.

Bug:  773713 
Change-Id: I031542ad09e1608eba768896a8198f8226bd5e38
Reviewed-on: https://chromium-review.googlesource.com/842562
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525954}
[modify] https://crrev.com/2ff0a9383fb2be7c694408a6e30cf5b3aade8292/third_party/WebKit/LayoutTests/TestExpectations

Comment 10 by phistuck@gmail.com, Dec 22 2017

Can this bug be marked as fixed?
Status: Fixed (was: Started)
Summary: Implement `import.meta.url` (was: Implement `import.meta`)
import.meta might also contains import.meta.scriptElement.
However, the spec discussion related to introducing import.meta.scriptElement is still open (https://github.com/whatwg/html/issues/1013), so having separate crbug issues is better.

Changing this as Implement `import.meta.url` and closing as fixed.
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14d350d474272ad31b29d5b4897c9b1deba2ff52

commit 14d350d474272ad31b29d5b4897c9b1deba2ff52
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Mon Oct 01 02:36:27 2018

[ES6 modules] Enable dynamic import and import.meta by default without feature flags

Retire the flags now that it is very unlikely we'll revert them.

Bug:  711706 ,  773713 
Change-Id: I854c5be068b42ef5fb58fe23f45ba1af107ece9a
Reviewed-on: https://chromium-review.googlesource.com/1250681
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595371}
[modify] https://crrev.com/14d350d474272ad31b29d5b4897c9b1deba2ff52/chrome/browser/about_flags.cc
[modify] https://crrev.com/14d350d474272ad31b29d5b4897c9b1deba2ff52/content/child/runtime_features.cc
[modify] https://crrev.com/14d350d474272ad31b29d5b4897c9b1deba2ff52/content/public/common/content_features.cc
[modify] https://crrev.com/14d350d474272ad31b29d5b4897c9b1deba2ff52/content/public/common/content_features.h
[modify] https://crrev.com/14d350d474272ad31b29d5b4897c9b1deba2ff52/content/renderer/render_process_impl.cc
[modify] https://crrev.com/14d350d474272ad31b29d5b4897c9b1deba2ff52/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
[modify] https://crrev.com/14d350d474272ad31b29d5b4897c9b1deba2ff52/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/14d350d474272ad31b29d5b4897c9b1deba2ff52/third_party/blink/renderer/platform/runtime_enabled_features.json5

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3888464b0adb2e905a60d50041ab2639c47971b

commit d3888464b0adb2e905a60d50041ab2639c47971b
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Wed Oct 17 04:51:24 2018

ES Modules: Remove unnecessary flags for ES Modules

This CL removes unnecessary flags and descriptions for import.meta and
dynamic import.

- import.meta was shipped in M64:
https://www.chromestatus.com/feature/5637509807603712
- dynamic import was shipped in M63:
https://www.chromestatus.com/feature/5684934484164608

Bonus: This change stops running duplicate virtual tests for import.meta.

Bug:  711706 ,  773713 
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If4de7343f0c5d6b449e50804de6254eb9cc191d0
Reviewed-on: https://chromium-review.googlesource.com/c/1285493
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600279}
[modify] https://crrev.com/d3888464b0adb2e905a60d50041ab2639c47971b/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/d3888464b0adb2e905a60d50041ab2639c47971b/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/d3888464b0adb2e905a60d50041ab2639c47971b/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/d3888464b0adb2e905a60d50041ab2639c47971b/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/2a94e36850459037c558613bc5292047567ccdf4/third_party/WebKit/LayoutTests/virtual/import-meta-url/external/wpt/html/semantics/scripting-1/the-script-element/module/import-meta/README.txt
[modify] https://crrev.com/d3888464b0adb2e905a60d50041ab2639c47971b/third_party/blink/public/platform/web_runtime_features.h

Sign in to add a comment