Create a mojo client in NoteTakingHelper instead.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92edf62ebb2e6f4510ef4010148bbce94646990a commit 92edf62ebb2e6f4510ef4010148bbce94646990a Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Fri Oct 13 22:08:01 2017 Move note taking related methods out of PaletteDelegate Create ash::NoteTakingController and have chromeos::NoteTakingHelper communicate with it over mojo. Bug: 773698 Test: ash_unittests --gtest_filter=CreateNoteTest.* Change-Id: Ib41e9adc0d95624c450097c48d1c0779ed8ee763 Reviewed-on: https://chromium-review.googlesource.com/713195 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#508837} [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/BUILD.gn [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/mojo_interface_factory.cc [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/mus/manifest.json [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/mus/standalone/manifest.json [add] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/note_taking_controller.cc [add] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/note_taking_controller.h [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/palette_delegate.h [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/public/interfaces/BUILD.gn [add] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/public/interfaces/note_taking_controller.mojom [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/shell.cc [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/shell.h [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/shell/shell_delegate_impl.cc [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/system/palette/test_palette_delegate.cc [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/system/palette/test_palette_delegate.h [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/system/palette/tools/create_note_action.cc [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/system/palette/tools/create_note_unittest.cc [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/chrome/browser/chromeos/BUILD.gn [add] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/chrome/browser/chromeos/note_taking_controller_client.cc [add] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/chrome/browser/chromeos/note_taking_controller_client.h [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/chrome/browser/chromeos/note_taking_helper.cc [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/chrome/browser/chromeos/note_taking_helper.h [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/chrome/browser/ui/ash/palette_delegate_chromeos.cc [modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/chrome/browser/ui/ash/palette_delegate_chromeos.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9d2fb1b87f68fe2e575eb0f039436ab80715a42 commit f9d2fb1b87f68fe2e575eb0f039436ab80715a42 Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Tue Oct 17 02:31:58 2017 Add unit test for NoteTakingControllerClient Bug: 773698 Test: unit_tests --gtest_filter=NoteTakingHelperTest.* Change-Id: I66ec6b95b24597df199df780efbd33f5076c90d7 Reviewed-on: https://chromium-review.googlesource.com/721693 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#509223} [modify] https://crrev.com/f9d2fb1b87f68fe2e575eb0f039436ab80715a42/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/f9d2fb1b87f68fe2e575eb0f039436ab80715a42/chrome/browser/chromeos/note_taking_controller_client.cc [modify] https://crrev.com/f9d2fb1b87f68fe2e575eb0f039436ab80715a42/chrome/browser/chromeos/note_taking_controller_client.h [modify] https://crrev.com/f9d2fb1b87f68fe2e575eb0f039436ab80715a42/chrome/browser/chromeos/note_taking_helper.h [modify] https://crrev.com/f9d2fb1b87f68fe2e575eb0f039436ab80715a42/chrome/browser/chromeos/note_taking_helper_unittest.cc
Comment 1 by kaznacheev@chromium.org
, Oct 11 2017