New issue
Advanced search Search tips

Issue 773698 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 761120



Sign in to add a comment

Move note taking related methods out of PaletteDelegate

Project Member Reported by kaznacheev@chromium.org, Oct 11 2017

Issue description

Create a mojo client in NoteTakingHelper instead.

 
Blocking: 761120
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92edf62ebb2e6f4510ef4010148bbce94646990a

commit 92edf62ebb2e6f4510ef4010148bbce94646990a
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Fri Oct 13 22:08:01 2017

Move note taking related methods out of PaletteDelegate

Create ash::NoteTakingController and have chromeos::NoteTakingHelper
communicate with it over mojo.

Bug:  773698 
Test: ash_unittests --gtest_filter=CreateNoteTest.*
Change-Id: Ib41e9adc0d95624c450097c48d1c0779ed8ee763
Reviewed-on: https://chromium-review.googlesource.com/713195
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508837}
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/BUILD.gn
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/mojo_interface_factory.cc
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/mus/manifest.json
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/mus/standalone/manifest.json
[add] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/note_taking_controller.cc
[add] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/note_taking_controller.h
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/palette_delegate.h
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/public/interfaces/BUILD.gn
[add] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/public/interfaces/note_taking_controller.mojom
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/shell.cc
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/shell.h
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/system/palette/test_palette_delegate.cc
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/system/palette/test_palette_delegate.h
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/system/palette/tools/create_note_action.cc
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/ash/system/palette/tools/create_note_unittest.cc
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/chrome/browser/chromeos/note_taking_controller_client.cc
[add] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/chrome/browser/chromeos/note_taking_controller_client.h
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/chrome/browser/chromeos/note_taking_helper.cc
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/chrome/browser/chromeos/note_taking_helper.h
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/chrome/browser/ui/ash/palette_delegate_chromeos.cc
[modify] https://crrev.com/92edf62ebb2e6f4510ef4010148bbce94646990a/chrome/browser/ui/ash/palette_delegate_chromeos.h

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: archived (was: Fixed)

Comment 7 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment