New issue
Advanced search Search tips

Issue 773684 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

DCHECK: GpuProcessHost::~GpuProcessHost

Project Member Reported by siggi@chromium.org, Oct 11 2017

Issue description

After the GPU process exits often enough, it looks like we end up trying to get the termination status of a process that was never launched.

GpuProcessHost::~GpuProcessHost() {

...

 std::string message;
  bool block_offscreen_contexts = true;
  if (!in_process_) {
    int exit_code;
    base::TerminationStatus status = process_->GetTerminationStatus(
        false /* known_dead */, &exit_code);  <<< IN HERE
    UMA_HISTOGRAM_ENUMERATION("GPU.GPUProcessTerminationStatus",
                              status,
                              base::TERMINATION_STATUS_MAX_ENUM);

    if (status == base::TERMINATION_STATUS_NORMAL_TERMINATION ||

 

Comment 1 by siggi@chromium.org, Oct 11 2017

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a14628013711891a600348b52153d9b36c2ba067

commit a14628013711891a600348b52153d9b36c2ba067
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Wed Oct 11 18:07:04 2017

Fix a DCHECK on switchover to SwiftShader.

Attempting to get the termination status of a process that was
never launched is unwise.

TBR: piman@chromium.org
Bug:  773684 
Change-Id: Ib03b326bd13499192c9b1227285905c59d0dd751
Reviewed-on: https://chromium-review.googlesource.com/712701
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508038}
[modify] https://crrev.com/a14628013711891a600348b52153d9b36c2ba067/content/browser/gpu/gpu_process_host.cc

Comment 3 by siggi@chromium.org, Oct 11 2017

Status: Fixed (was: Started)

Sign in to add a comment