Invalid width in viewport meta tag falls back to arbitrary value |
||
Issue descriptionChrome Version : 63.0.3230.0 OS Version: Android URLs (if applicable) : http://bokand.github.io/invalid-viewport.html Other browsers tested: Firefox: OK What steps will reproduce the problem? 1. Visit the above page which has a malformed width attribute in the viewport meta tag What is the expected result? We should fallback to a reasonable default in this case What happens instead of that? We seem to fallback to the minimum allowed viewport width (I'm seeing 82px) which doesn't make any sense at all. Firefox appears to fallback as if the width isn't specified (i.e. 980px) which is reasonable, we should do the same.
,
Oct 13 2017
Chrome falls back to 82px (Chrome on iOS uses a WebKit WebView). So in this case fixing it will improve interop between both Firefox and Safari.
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/145660d6a05041e0da6a412598a29741b9efe816 commit 145660d6a05041e0da6a412598a29741b9efe816 Author: chaopeng <chaopeng@chromium.org> Date: Fri Oct 13 20:30:03 2017 Invalid viewport meta width/height value should fall back to auto. Currently invalid viewport meta width/height value fall back to 0.0. But fall back to auto make more sense to developer. Bug: 773653 Change-Id: I3a9243a171101cfdbd10f9f71c9fe7288b44d7c7 Reviewed-on: https://chromium-review.googlesource.com/713876 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#508800} [modify] https://crrev.com/145660d6a05041e0da6a412598a29741b9efe816/third_party/WebKit/Source/core/html/HTMLMetaElement.cpp [modify] https://crrev.com/145660d6a05041e0da6a412598a29741b9efe816/third_party/WebKit/Source/core/page/ViewportTest.cpp [modify] https://crrev.com/145660d6a05041e0da6a412598a29741b9efe816/third_party/WebKit/Source/core/testing/data/viewport/viewport-52.html [modify] https://crrev.com/145660d6a05041e0da6a412598a29741b9efe816/third_party/WebKit/Source/core/testing/data/viewport/viewport-53.html [modify] https://crrev.com/145660d6a05041e0da6a412598a29741b9efe816/third_party/WebKit/Source/core/testing/data/viewport/viewport-55.html
,
Oct 18 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bokan@chromium.org
, Oct 11 2017