Toolbar of stackview needs to adapt to the different height of toolbars. |
||||||||||
Issue descriptionTight now, the StackView considers the height of the toolbar to be constant. This is a problem on the iPhone X, where the height of the toolbar changes with the orientation. To reproduce: (1) On iPhone X, enable the "Safe area compatible toolbar" experimental flag. (2) Relaunch chrome. (3) Visit a website (e.g. wikipedia). (4) Enter the Stack View. Notice that the StackView's toolbar has the correct height. (5) Leave the StackView. (6) Change orientation. (7) Enter the Stack View. Notice that the StackView's toolbar has an incorrect height.
,
Oct 11 2017
,
Oct 11 2017
,
Oct 19 2017
Sergio are you working on this?
,
Oct 19 2017
I will start today and report on any advances I make. Thanks for the reminder Estelle, I know this is high priority so I'll keep you updated.
,
Oct 23 2017
Partly fixed by https://chromium-review.googlesource.com/c/chromium/src/+/733163
,
Oct 24 2017
,
Oct 25 2017
Fix mentionned in #6 has landed.
,
Oct 25 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-63; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-63 label, otherwise remove Merge-TBD label. Thanks.
,
Nov 7 2017
Assigning to you Peter. Do we have plan to merge this again?
,
Nov 13 2017
Verified on 64.0.3267.0 in iPhoneX simulator In Landscape the height of the tool bar looks good in stack view Link to screenshot: https://drive.google.com/a/google.com/file/d/1E2IgXfbzAVr0cEafrVEAAyUcvTLxZ3Of/view?usp=sharing
,
Dec 4 2017
pkl@ I guess your answer to comment 10 was No so I am removing merge-TBD here. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by jif@chromium.org
, Oct 11 2017A good start would be to add in stack_view_controller.mm the following: - (void)viewSafeAreaInsetsDidChange { [super viewSafeAreaInsetsDidChange]; CGRect newToolbarFrame = [_toolbarController view].frame; newToolbarFrame.size.height = [_toolbarController preferredToolbarHeightWhenAlignedToTopOfScreen]; [[_toolbarController view] setFrame:newToolbarFrame]; }