New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 773627 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Dec 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Use FaviconAttributesProvider from GoogleLandingMediator

Project Member Reported by mastiz@chromium.org, Oct 11 2017 
This is a refactoring task that is iOS-specific. At the time of filing this bug, the CL that makes this need more obvious is under review: https://chromium-review.googlesource.com/c/chromium/src/+/711836/1

Presumably, using the provider could avoid duplicated code.

Comment 1 by liaoyuke@chromium.org, Oct 12 2017

Components: UI>Browser>NewTabPage

Comment 2 by fhorschig@chromium.org, Oct 13 2017

Labels: zine-triaged

Comment 3 by gambard@chromium.org, Oct 16 2017 

The GoogleLandingMediator will be heavily refactored once ContentSuggestions is the default, and might be completely removed.
Keeping this bug open to make sure GoogleLandingMediator is no longer using favicons  once the refactoring is done.

Comment 4 by gambard@chromium.org, Dec 5 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment