Chrome OS native notification doesn't get focus by click while ARC notification does |
||||||||
Issue descriptionChrome Version: ToT OS: Chrome OS What steps will reproduce the problem? (1) Create Chrome OS native notification by Shift-Esc (2) Create ARC notification (3) Create browser window by Ctrl-N (4) Click on the ARC notification and check the focus moves (5) Move back to the browser window and click on the native notification What is the expected result? Chrome OS native notification should also get focus What happens instead? Browser caption bar color doesn't change, and the focus doesn't move. It is better to fix in terms of ARC consistency, but also this is a blocker item for inline reply implementation.
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcfd0545c42eb980b1769a1aa769b6708b3b53e3 commit dcfd0545c42eb980b1769a1aa769b6708b3b53e3 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Mon Oct 16 05:18:14 2017 Activate native notification widget when clicked Previously, Chrome OS native notification (NotificationViewMD) doesn't get activated on click, while ARC notification (ArcNotificationView) does. This CL adds NotificationViewMD::EventForwarder, based on the implementation of ArcNotificationContentView::EventForwarder. This change is required for two reasons: - Consistency with ARC notifications - Future implementation of inline reply notification TEST=manual BUG= 773618 Change-Id: I728cdfdd45896cf2a317b9d7e41d1a097e58aa4f Reviewed-on: https://chromium-review.googlesource.com/718056 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#508987} [modify] https://crrev.com/dcfd0545c42eb980b1769a1aa769b6708b3b53e3/ui/message_center/views/notification_view_md.cc [modify] https://crrev.com/dcfd0545c42eb980b1769a1aa769b6708b3b53e3/ui/message_center/views/notification_view_md.h
,
Oct 17 2017
,
Oct 17 2017
,
Oct 17 2017
Raise to P1 as blocker for P1 regression https://crbug.com/763766
,
Oct 18 2017
,
Oct 18 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 18 2017
Oh, forgot to mention but verified on 64.0.3242.0
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/470ad07ba2418ace31a4a6b06b006e750bc08100 commit 470ad07ba2418ace31a4a6b06b006e750bc08100 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Oct 18 05:55:32 2017 Activate native notification widget when clicked Previously, Chrome OS native notification (NotificationViewMD) doesn't get activated on click, while ARC notification (ArcNotificationView) does. This CL adds NotificationViewMD::EventForwarder, based on the implementation of ArcNotificationContentView::EventForwarder. This change is required for two reasons: - Consistency with ARC notifications - Future implementation of inline reply notification TEST=manual BUG= 773618 Change-Id: I728cdfdd45896cf2a317b9d7e41d1a097e58aa4f Reviewed-on: https://chromium-review.googlesource.com/718056 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#508987}(cherry picked from commit dcfd0545c42eb980b1769a1aa769b6708b3b53e3) Reviewed-on: https://chromium-review.googlesource.com/725006 Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#47} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/470ad07ba2418ace31a4a6b06b006e750bc08100/ui/message_center/views/notification_view_md.cc [modify] https://crrev.com/470ad07ba2418ace31a4a6b06b006e750bc08100/ui/message_center/views/notification_view_md.h
,
Nov 8 2017
Verified on M-63 beta build (10032.30.0, 63.0.3239.39). |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tetsui@chromium.org
, Oct 13 2017