New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773616 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

ScreenFinderTest and VideoFileFrameGeneratorTest failing consistently

Project Member Reported by fhorschig@chromium.org, Oct 11 2017

Issue description

Two interactive_ui_tests are failing on 2 builders

Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29

The tests in question are: 
* telemetry.internal.image_processing.screen_finder_unittest.ScreenFinderTest.testBasicFunctionality
* telemetry.internal.image_processing.video_file_frame_generator_unittest.VideoFileFrameGeneratorTest.testVideoFileFrameGeneratorSkipFrames
* telemetry.internal.image_processing.video_file_frame_generator_unittest.VideoFileFrameGeneratorTest.testVideoFileFrameGeneratorSuccess

First failing build:
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/63820
 
Labels: Pri-1
Seems to be an ancient issue (Apr 25) [1] that was disabled on all platforms and at some point reenabled again. I will disable it and add the previous owners here.


[1] https://github.com/catapult-project/catapult/issues/3510 is linked in the source code: https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/image_processing/screen_finder_unittest.py?q=ScreenFinderTest&sq=package:chromium&l=21
Cc: dpranke@chromium.org
 Issue 773589  has been merged into this issue.
Cc: nednguyen@chromium.org
Components: Internals>GPU>Testing Tests>Telemetry Speed>Telemetry
Labels: Type-Bug
Owner: kainino@chromium.org
Status: Assigned (was: Started)
Adding owners/components from related CLs and issue 711307.
Abandoned https://crrev.com/c/712049 and trying to disable the tests according to https://github.com/catapult-project/catapult/blob/master/CONTRIBUTING.md now.
WIP waiting to be landed and rolled out by deps-roller: https://crrev.com/c/712052
Cc: kbr@chromium.org
Cc: ashleymarie@chromium.org
 Issue 773477  has been merged into this issue.
Labels: -Sheriff-Chromium

Comment 9 by kbr@chromium.org, Oct 11 2017

Cc: nedngu...@google.com kainino@chromium.org
Owner: fhorschig@chromium.org
Kai worked on getting the numpy and cv2 dependencies correctly downloaded onto test machines. These preexisting tests hadn't run in recent history and it was out of scope to debug them, which is why they were disabled.

The cause of the new failures was https://chromium.googlesource.com/chromium/src/+/5e95315b03684b2f922dc9bd1b9cefe21bb89c30 , which downloaded these binaries onto more machines on the waterfall, implicitly enabling these tests.

fhorschig@, thanks for disabling the tests more broadly. Let me assign this to you to close.

I'm confused ...

nednguyen@ - First, shouldn't we have already been downloading the dependencies on any bot that was running the tests? Second, why is what we run dynamically determined by what we happen to have present on the machine?
actually, those questions are probably better answered in bug 773357 :).
Status: Fixed (was: Assigned)
Components: Test>Telemetry
Components: -Speed>Telemetry

Sign in to add a comment