New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 773611 link

Starred by 0 users
Status: Fixed
Owner:
yukishiino@chromium.org
Closed: Oct 2017
Cc:
yukishiino@chromium.org
█ w...@chromium.org
peria@chromium.org
jbroman@chromium.org
haraken@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Task



Sign in to add a comment

Make ScriptWrappable inherit from GarbageCollectedFinalized.

Project Member Reported by yukishiino@chromium.org, Oct 11 2017 
Let's make ScriptWrappable inherit from GarbageCollectedFinalized.

Currently, EventTarget inherits from GarbageCollectedFinalized.  Almost everything wrappable inherits from EventTarget, however, not exactly everything.

This is causing a non-negligible disadvantage.  We currently need
- WrapperTypeInfo::trace_function
- WrapperTypeInfo::trace_wrappers_function
to trace Oilpan objects and V8 objects.  Given there are 1,000 WrapperTypeInfos, we're wasting about 16k bytes just because ScriptWrappable is not GarbageCollected.

Also there will be more chances of optimizations because
- GarbageCollected must be the top of inheritance.
- ScriptWrappable will be the top, too.
- Thus, (void*)script_wrallable == (void*)any_wrappable_type
This means
- ScriptWrappable::ToImpl<T> will be simplified.
- Generated V8T::ToImpl will be no need.
  (The offset will be always zero.)

There would be more wins.

Comment 1 by yukishiino@chromium.org, Oct 11 2017

Cc: w...@chromium.org haraken@chromium.org jbroman@chromium.org yukishiino@chromium.org
+cc: watk@, feel free to take this task if you're interested in.

Comment 2 by yukishiino@chromium.org, Oct 13 2017

Owner: yukishiino@chromium.org
Status: Started (was: Available)
I found that my work needs this issue to be resolved.  Let me give it a try.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22df232ae766ba06f2b4abf7ade2a4ac4193343e

commit 22df232ae766ba06f2b4abf7ade2a4ac4193343e
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Tue Oct 24 07:54:56 2017

v8binding: Makes ScriptWrappable inherit from GarbageCollectedFinalized.

It's reasonable and simple that ScriptWrappable inherits from
GarbageCollected.  Currently all subclasses of ScriptWrappable need to
inherit GarbageCollected as their own responsibility, which is not
awesome.  The changes in this patch are mostly straightforward and
mechanical, except for the following points.  (Reviewers should be
interested in changes under platform/bindings/ at least.)

a) All subclasses of ScriptWrappable are now GCFinalized.
Some of the subclasses were GarbageCollected without Finalized, so this
CL increases the number of GCFinalized instances.  However, the number
is expected to be low because EventTarget has been GCFinalized.

b) DOMWrapperMap stores |UntracedMember<ScriptWrappable>| instead of
|ScriptWrappable*|.  Now ScriptWrappable is GarbageCollectedFinalized,
so it should be held as Member<ScriptWrappable> in general.  However,
DOMWrapperMap does not need to make ScriptWrappables alive because it's
an inverse weak mapping.  V8 wrappers must make ScriptWrappables alive.
So DOMWrapperMap holds |UntracedMember<ScriptWrappable>| instead of
Member<ScriptWrappable>.

c) SVGAnimatedPropertyBase inherits from GarbageCollectedMixin.
SVGAnimatedPropertyBase has been inheriting from GCFinalized, however,
now ScriptWrappable inherits from GCFinalized.  So,
SVGAnimatedPropertyBase now inherits from GCMixin.
As EBO (Empty Base class Optimization) is not supported on Windows,
this change may increase the size of non-ScriptWrappable subclasses of
SVGAnimatedPropertyBase by sizeof(void*).

NOPRESUBMIT=true

Bug:  773611 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iad40f96b3d966515d9d8e624410a33092752e3f0
Reviewed-on: https://chromium-review.googlesource.com/719116
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511055}
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.h.tmpl
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/animation/AnimationEffectTimingReadOnly.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/animation/AnimationEffectTimingReadOnly.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/animation/AnimationTimeline.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/animation/WorkletAnimationBase.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/clipboard/DataTransfer.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/clipboard/DataTransferItem.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/clipboard/DataTransferItemList.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/clipboard/DataTransferItemList.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/CSSRule.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/CSSRule.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/CSSRuleList.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/CSSStyleDeclaration.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/DOMWindowCSS.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/FontFace.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/MediaList.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/MediaList.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/StyleMedia.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/StyleMedia.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/StyleSheet.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/StyleSheetList.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/StyleSheetList.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/cssom/CSSStyleVariableReferenceValue.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/AccessibleNodeList.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/AccessibleNodeList.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/DOMException.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/DOMImplementation.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/DOMImplementation.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/DOMStringList.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/DOMStringMap.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/DOMTokenList.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/DOMTokenList.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/IdleDeadline.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/Iterator.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/MessageChannel.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/MessageChannel.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/MutationObserver.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/MutationObserver.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/MutationRecord.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/NamedNodeMap.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/NamedNodeMap.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/NodeIterator.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/NodeIterator.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/NodeList.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/Range.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/Range.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/StaticRange.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/StaticRange.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/TreeWalker.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/TreeWalker.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/events/Event.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/events/Event.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/events/EventTarget.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/trustedtypes/TrustedHTML.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/trustedtypes/TrustedScriptURL.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/dom/trustedtypes/TrustedURL.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/editing/DOMSelection.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/fileapi/Blob.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/fileapi/FileList.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/fileapi/FileList.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/fileapi/FileReaderSync.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/frame/BarProp.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/frame/BarProp.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/frame/External.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/frame/History.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/frame/History.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/frame/Location.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/frame/Location.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/frame/Navigator.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/frame/Navigator.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/frame/Report.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/frame/ReportBody.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/frame/ReportingObserver.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/frame/ReportingObserver.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/frame/Screen.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/frame/Screen.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/geometry/DOMPointReadOnly.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/geometry/DOMQuad.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/geometry/DOMRectList.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/geometry/DOMRectList.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/geometry/DOMRectReadOnly.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/HTMLCollection.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/HTMLCollection.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/ImageData.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/ImageData.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/TextMetrics.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/TimeRanges.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/custom/CustomElementRegistry.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/custom/CustomElementRegistry.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/forms/FormData.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/forms/FormData.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/forms/ValidityState.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/media/MediaError.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/track/AudioTrack.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/track/AudioTrack.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/track/TextTrackCueList.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/track/TextTrackCueList.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/track/VideoTrack.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/track/VideoTrack.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/input/InputDeviceCapabilities.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/input/Touch.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/input/Touch.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/input/TouchList.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/input/TouchList.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/inspector/DevToolsHost.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/inspector/InspectorOverlayHost.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/inspector/InspectorOverlayHost.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/intersection_observer/IntersectionObserver.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/intersection_observer/IntersectionObserver.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/intersection_observer/IntersectionObserverEntry.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/intersection_observer/IntersectionObserverEntry.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/mojo/Mojo.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/mojo/MojoHandle.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/mojo/MojoWatcher.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/mojo/MojoWatcher.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/page/PagePopupController.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/page/scrolling/ScrollState.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/resize_observer/ResizeObserver.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/resize_observer/ResizeObserver.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/resize_observer/ResizeObserverEntry.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/resize_observer/ResizeObserverEntry.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAngleTearOff.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedAngle.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedAngle.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedBoolean.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedEnumerationBase.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedInteger.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedInteger.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedIntegerOptionalInteger.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedLength.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedLengthList.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedNumber.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedNumber.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedNumberList.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedNumberOptionalNumber.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedPath.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedPointList.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedPreserveAspectRatio.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedRect.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedString.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedString.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGAnimatedTransformList.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGGeometryElement.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGLengthListTearOff.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGLengthTearOff.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGMatrixTearOff.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGMatrixTearOff.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGNumberListTearOff.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGNumberTearOff.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGNumberTearOff.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGPointListTearOff.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGPointTearOff.cpp
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGPointTearOff.h
[modify] https://crrev.com/22df232ae766ba06f2b4abf7ade2a4ac4193343e/third_party/WebKit/Source/core/svg/SVGPol

Comment 4 by yukishiino@chromium.org, Oct 25 2017

Cc: peria@chromium.org
Status: Fixed (was: Started)
To watk@, peria@ or whoever interested,

I believe that now we can easily get rid of
- WrapperTypeInfo::trace_function
- WrapperTypeInfo::trace_wrappers_function
because ScriptWrappable inherits from GarbageCollected and TraceWrapperBase.  So, removing them should be pretty low hanging fruit.  Please take it if you have time.
►

Sign in to add a comment