New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773610 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

HostedAppTest.CtrlClickLink extremley flaky on chromium.mac/Mac10.12 Tests

Project Member Reported by fhorschig@chromium.org, Oct 11 2017

Issue description

Labels: -Sheriff-Chromium
Removing sheriff label as disabling is already happening with https://crrev.com/c/711847
Labels: -Filed-Via-SoM
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28c2f9120f702f1dde5614f34c805f0fc0988ba8

commit 28c2f9120f702f1dde5614f34c805f0fc0988ba8
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Wed Oct 11 09:17:29 2017

Disable flaky HostedAppTest.CtrlClickLink test

This test failed 6 out of 10 runs. Disabling it until fixed.

TBR=ortuno@chromium.org, sky@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Bug:  773610 
Change-Id: I4a51af4fcc95d32f753df1d1a66810a84243ebee
Reviewed-on: https://chromium-review.googlesource.com/711847
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507934}
[modify] https://crrev.com/28c2f9120f702f1dde5614f34c805f0fc0988ba8/chrome/browser/ui/extensions/hosted_app_browsertest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f681e47b5a25838e5792280a87e2dcf60cbed0d

commit 5f681e47b5a25838e5792280a87e2dcf60cbed0d
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Thu Oct 12 11:17:28 2017

Disable flaky HostedAppTest.CtrlClickLink on MacOSX only

This test fails mainly on MacOSX. It shouldn't be disabled on all
platforms unless it starts to flake there, too.

TBR=ortuno@chromium.org, sky@chromium.org

Bug:  773610 
Change-Id: Ide27b3aa596d131cfff22e0536c4a27750d4ade3
Reviewed-on: https://chromium-review.googlesource.com/715796
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508310}
[modify] https://crrev.com/5f681e47b5a25838e5792280a87e2dcf60cbed0d/chrome/browser/ui/extensions/hosted_app_browsertest.cc

Comment 5 by ortuno@chromium.org, Oct 12 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43d5d2c65be39b04649943de8a05e201198da951

commit 43d5d2c65be39b04649943de8a05e201198da951
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Mon Oct 16 01:11:27 2017

hosted-apps: Use embedded_server's URLs so that the page loads successfully

We need a page to load successfully so that we can run JavaScript on it.
Also simplifies test by using a file with a link in it and clicking
that link.

Bug:  773610 
Change-Id: If38595963d890086db3fb17d18fc8a955c0b789c
Reviewed-on: https://chromium-review.googlesource.com/714498
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508967}
[modify] https://crrev.com/43d5d2c65be39b04649943de8a05e201198da951/chrome/browser/ui/extensions/hosted_app_browsertest.cc

Comment 7 by ortuno@chromium.org, Oct 16 2017

Status: Fixed (was: Started)

Sign in to add a comment