New issue
Advanced search Search tips

Issue 773609 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

webkit_layout_tests failing on 4 builders

Project Member Reported by keishi@chromium.org, Oct 11 2017

Issue description

Cc: keishi@chromium.org
Labels: Pri-1
Owner: hta@chromium.org
Status: Assigned (was: Available)
The test was likely flaky before that CL and is also tracked in  issue 71540 .
The owner knows and agreed to disable the test with the reland.
* issue 771540  ... leading 7 was missing
Labels: -Sheriff-Chromium
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68e8a89834946651c5ab54de10710be2cc21b68c

commit 68e8a89834946651c5ab54de10710be2cc21b68c
Author: Harald Alvestrand <hta@chromium.org>
Date: Wed Oct 11 14:23:02 2017

Reland "Remove MockWebRTCPeerConnectionHandler""

This reverts commit 22f808a28c411c51d5f93bc505347be671a37f1d.

Reason for revert: Marking failing test as flaky.

TBR=peter@chromium.org,dpranke@chromium.org,hbos@chromium.org,foolip@chromium.org,jochen@chromium.org

Bug:  706359 ,  773609 ,  771540 
Change-Id: I68e9b3e511f0039690f2e8d09667ca6a754400f7
Reviewed-on: https://chromium-review.googlesource.com/712094
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507978}
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/content/shell/renderer/layout_test/layout_test_content_renderer_client.h
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/content/shell/test_runner/BUILD.gn
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/content/shell/test_runner/mock_webrtc_data_channel_handler.cc
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/content/shell/test_runner/mock_webrtc_data_channel_handler.h
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/content/shell/test_runner/mock_webrtc_dtmf_sender_handler.cc
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/content/shell/test_runner/mock_webrtc_dtmf_sender_handler.h
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/content/shell/test_runner/mock_webrtc_peer_connection_handler.cc
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/content/shell/test_runner/mock_webrtc_peer_connection_handler.h
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/content/shell/test_runner/web_frame_test_proxy.h
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/content/shell/test_runner/web_test_interfaces.cc
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCCertificate-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCConfiguration-bundlePolicy-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCConfiguration-iceServers-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCConfiguration-rtcpMuxPolicy-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDataChannel-bufferedAmount-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDataChannel-id-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDataChannel-send-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDtlsTransport-getRemoteCertificates-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCIceTransport-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-addIceCandidate-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-canTrickleIceCandidates-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-constructor-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-createAnswer-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-createDataChannel-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-createOffer-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-iceGatheringState-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-idl-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-ondatachannel-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-onnegotiationneeded-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-ontrack-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-offer-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-pranswer-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-rollback-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-answer-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-offer-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-pranswer-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-rollback-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/datachannel-emptystring-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/external/wpt/webrtc/getstats-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/interfaces-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/external/wpt/webrtc/no-media-call-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/external/wpt/webrtc/promises-call-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createAnswer-promise.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createAnswer.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createOffer-promise-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createOffer-promise.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createOffer.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-datachannel-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-dtmf-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-getReceivers.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-getStats-promise.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-ice-promise-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-lifetime-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-localDescription-promise.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-localDescription.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remoteDescription-promise.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remoteDescription.html
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-stats-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-stats.html
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-statsSelector-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-statsSelector.html

Comment 6 by hta@chromium.org, Oct 16 2017

Status: Fixed (was: Assigned)
Fixed in https://chromium-review.googlesource.com/c/chromium/src/+/712094

Sign in to add a comment