[PlzNavigate] investigate posting onPageStarted from the PlzNavigate shouldOverrideUrlLoading path |
||
Issue descriptionwe post onPageStart in the sync-ipc ShouldOverrideUrlLoading path here: https://cs.chromium.org/chromium/src/android_webview/java/src/org/chromium/android_webview/AwContents.java?l=1&rcl=a3e6b4ed329668a56f6d97c126fc637054a39d2a It is not clear that the logic for posting onPageStarted from that path is correct since the following CL landed https://chromium.googlesource.com/chromium/src/+/1ea0edbb6c8d845aa5d63d1298f591d74d26088c and furthermore we should probably post onPageStarted from the new plzNavigate shouldOverrideUrlLoading path. Next steps: 1. investigate why onPageStarted is posted from the shouldOverrideUrlLoading path, and what breaks if it's not posted 2. figure out whether the new plzNavigate path should also post onPageStarted 3. check why our existing onPageStarted instrumentation tests don't fail for plzNavigate (if they don't)
,
Oct 11 2017
Right, I'm a bit confused when it comes to the case where PlzNavigate is turned on - in that case we will always post onPageStarted from InterceptNavigationDelegateImpl, while with the old code path we would only post onPageStarted if shouldOverrideUrlLoading returns false. Isn't that an unwanted behaviour change?
,
Oct 11 2017
With PlzNavigate, if ShouldOverrideUrlLoading return true in NavigationRequest::BeginNavigation(), we don't create a navigation (The navigation is represented by the NavigationHandle) It means that the InterceptNavigationThrottle is not created. So it can't post a onPageStarted event. The behavior is the same with/without PlzNavigate AFAIK
,
Oct 11 2017
Ah ok, cool, would it be possible to add a comment about this somewhere for mere confused mortals like me? ;)
,
Oct 12 2017
Yes, I was confused too when I was trying to fix issues with ShouldOverrideUrlLoading, a comment would be nice. I will add it if I make or see a patch about this soon or in a separate CL then.
,
Oct 12 2017
Great, thanks!
,
Jun 19 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by arthurso...@chromium.org
, Oct 11 2017