Fix unclear catapult errors output in exceptions.py
Reported by
rkuk...@yandex-team.ru,
Oct 11 2017
|
||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0 Steps to reproduce the problem: Faced this problem when running core.stacktrace_unittest.TabStackTraceTest.testBadBreakpadFileIgnored What is the expected behavior? What went wrong? The test couldn't access /var/log/system.log and I got this output: Problem when trying to gather stack trace: Command '['tail', '-n', '200', '/var/log/system.log']' returned non-zero exit status 1 This error message is not correct since the problem had nothing with 'trying to gather stack trace'. And this says nothing about the python file where the error occurred. Did this work before? No Chrome version: Channel: n/a OS Version: Flash Version: I've already created a fix for this problem: https://chromium-review.googlesource.com/c/catapult/+/708263
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/67c01572b02248ec553a2064be7e5e065fb494b8 commit 67c01572b02248ec553a2064be7e5e065fb494b8 Author: Roman Kuksin <rkuksin@yandex-team.ru> Date: Thu Oct 12 12:49:34 2017 Refactoring: use logging.exception instead of logging.error Change-Id: Ia0ff87ff5c968765f7e2ea70f862124ebd0255d7 Bug: chromium:773603 Change-Id: Ia0ff87ff5c968765f7e2ea70f862124ebd0255d7 Reviewed-on: https://chromium-review.googlesource.com/708263 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/67c01572b02248ec553a2064be7e5e065fb494b8/telemetry/telemetry/core/exceptions.py
,
Jan 22 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by wangyix@chromium.org
, Oct 11 2017