This should allow us monitor the adoption of Web Manifests and understand how prominent Web Manifests are in the overall NTP impressions.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95cfea6d50e3b8fb37e1a436d5304f80c6661cf5 commit 95cfea6d50e3b8fb37e1a436d5304f80c6661cf5 Author: Mikel Astiz <mastiz@chromium.org> Date: Fri Oct 13 12:27:03 2017 Adopt FaviconAttributes interface more broadly We do this as a preparation for future patches that will add new properties associated to favicons, that are relevant for UMA logging in various places. Bug: 773593 Change-Id: Ifa99e90c84b90f8dd254a81f791b817a01e5526b Reviewed-on: https://chromium-review.googlesource.com/711836 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#508676} [modify] https://crrev.com/95cfea6d50e3b8fb37e1a436d5304f80c6661cf5/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/95cfea6d50e3b8fb37e1a436d5304f80c6661cf5/ios/chrome/browser/content_suggestions/content_suggestions_favicon_mediator.mm [modify] https://crrev.com/95cfea6d50e3b8fb37e1a436d5304f80c6661cf5/ios/chrome/browser/content_suggestions/ntp_home_mediator.mm [modify] https://crrev.com/95cfea6d50e3b8fb37e1a436d5304f80c6661cf5/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.h [modify] https://crrev.com/95cfea6d50e3b8fb37e1a436d5304f80c6661cf5/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm [modify] https://crrev.com/95cfea6d50e3b8fb37e1a436d5304f80c6661cf5/ios/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/95cfea6d50e3b8fb37e1a436d5304f80c6661cf5/ios/chrome/browser/ui/ntp/google_landing_data_source.h [modify] https://crrev.com/95cfea6d50e3b8fb37e1a436d5304f80c6661cf5/ios/chrome/browser/ui/ntp/google_landing_mediator.mm [modify] https://crrev.com/95cfea6d50e3b8fb37e1a436d5304f80c6661cf5/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm [add] https://crrev.com/95cfea6d50e3b8fb37e1a436d5304f80c6661cf5/ios/chrome/browser/ui/ntp/metrics.h [add] https://crrev.com/95cfea6d50e3b8fb37e1a436d5304f80c6661cf5/ios/chrome/browser/ui/ntp/metrics.mm [modify] https://crrev.com/95cfea6d50e3b8fb37e1a436d5304f80c6661cf5/ios/chrome/browser/ui/ntp/most_visited_cell.h [modify] https://crrev.com/95cfea6d50e3b8fb37e1a436d5304f80c6661cf5/ios/chrome/browser/ui/ntp/most_visited_cell.mm [modify] https://crrev.com/95cfea6d50e3b8fb37e1a436d5304f80c6661cf5/ios/chrome/browser/ui/ntp/ntp_tile_saver.mm [modify] https://crrev.com/95cfea6d50e3b8fb37e1a436d5304f80c6661cf5/ios/chrome/browser/ui/ntp/ntp_tile_saver_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5774c18be00ff4baa6290b40b95512827aa70a35 commit 5774c18be00ff4baa6290b40b95512827aa70a35 Author: Mikel Astiz <mastiz@chromium.org> Date: Thu Oct 26 10:59:51 2017 Break down NTP tile impressions by favicon type The patch introduces new UMA histograms and all the plumbing needed to log, at NTP impression time, which favicon type (regular favicon, touch icon or Web Manifest icon) was chosen to represent the tile (either the actual icon or for the computation of the fallback color). Bug: 773593 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5f3e0d1d735b6f23fdfa2b5d6b92ca4902dce08f Reviewed-on: https://chromium-review.googlesource.com/678724 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#511787} [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/android/BUILD.gn [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/android/DEPS [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemRow.java [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/android/java/src/org/chromium/chrome/browser/favicon/LargeIconBridge.java [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ConfirmImportantSitesDialogFragment.java [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSitesBridge.java [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileRenderer.java [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageLoadTest.java [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NtpUiCaptureTestData.java [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupUnitTest.java [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/browser/android/large_icon_bridge.cc [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/browser/android/ntp/most_visited_sites_bridge.cc [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/browser/android/ntp/most_visited_sites_bridge.h [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/browser/ui/search/ntp_user_data_logger_unittest.cc [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/browser/ui/search/search_ipc_router_unittest.cc [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/common/DEPS [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/common/instant_struct_traits.h [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/chrome/renderer/searchbox/searchbox_extension.cc [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/components/favicon_base/BUILD.gn [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/components/favicon_base/favicon_types.cc [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/components/favicon_base/favicon_types.h [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/components/ntp_tiles/metrics.cc [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/components/ntp_tiles/metrics_unittest.cc [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/components/ntp_tiles/ntp_tile_impression.cc [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/components/ntp_tiles/ntp_tile_impression.h [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/components/ntp_tiles/tile_visual_type.h [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/ios/chrome/browser/ui/ntp/metrics.mm [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/tools/metrics/histograms/enums.xml [modify] https://crrev.com/5774c18be00ff4baa6290b40b95512827aa70a35/tools/metrics/histograms/histograms.xml
Comment 1 by mvanouwe...@chromium.org
, Oct 11 2017