Implement inline reply for Chrome OS |
||||||||||||||||
Issue descriptionAndroid and Windows are supporting inline reply for web notifications (Issue 599859). And now it's time to start implementing it for Chrome OS. I think most of non-UI code are already implemented by their works, so what we do is implementing native UI for Chrome OS Message Center. We already support inline reply for ARC notification so we don't expect much works except UI (eg. forcusing, keyboard, IME ..., etc). But some tweak might be necessary. The UX work is filed separately: Issue 773585
,
Oct 11 2017
,
Oct 11 2017
,
Nov 7 2017
,
Nov 7 2017
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af6a15929770f14dc6c26d796d2bcf810a9410e0 commit af6a15929770f14dc6c26d796d2bcf810a9410e0 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Nov 16 03:35:05 2017 Add non-UI part support of notification inline reply. A web notification with the inline reply actions is already implemented on Android and Windows 10 native notifications. In order to support the feature on Chrome OS, we have to implement it in the views framework notification implementation. This CL adds the non user interface part of the notification inline reply support. TEST=manual BUG=599859, 773586 Change-Id: Ib6079f8dadd5e154e68a5c32b5c99df2fb100499 Reviewed-on: https://chromium-review.googlesource.com/756184 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#516969} [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ash/message_center/message_center_view.cc [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ash/message_center/message_center_view.h [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ash/message_center/message_center_view_unittest.cc [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ash/message_center/message_list_view_unittest.cc [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ui/arc/notification/arc_notification_content_view_unittest.cc [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ui/arc/notification/arc_notification_view_unittest.cc [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ui/message_center/fake_message_center.cc [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ui/message_center/fake_message_center.h [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ui/message_center/message_center.h [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ui/message_center/message_center_impl.cc [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ui/message_center/message_center_impl.h [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ui/message_center/message_center_observer.h [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ui/message_center/views/message_popup_collection.cc [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ui/message_center/views/message_popup_collection.h [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ui/message_center/views/message_view_delegate.h [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ui/message_center/views/notification_view_md_unittest.cc [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ui/message_center/views/notification_view_unittest.cc [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ui/message_center/views/toast_contents_view.cc [modify] https://crrev.com/af6a15929770f14dc6c26d796d2bcf810a9410e0/ui/message_center/views/toast_contents_view.h
,
Nov 17 2017
UI side implementation WIP here: https://crrev.com/c/776176
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc2743d59d86aa00720a69a863201643a6345d8e commit cc2743d59d86aa00720a69a863201643a6345d8e Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Nov 28 12:58:33 2017 Add notification inline reply support to Chrome OS. This adds UI side support of notification inline reply to NotificationViewMD, which is a View framework notification implementation used in Chrome OS. Several features are missing from this implementation. - Animation - Submit icon on the right side TEST=manual BUG= 773586 Change-Id: I65108a5cf6d4cf654972e260ca93f2712bf9fc68 Reviewed-on: https://chromium-review.googlesource.com/776176 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#519663} [modify] https://crrev.com/cc2743d59d86aa00720a69a863201643a6345d8e/ui/message_center/views/notification_view_md.cc [modify] https://crrev.com/cc2743d59d86aa00720a69a863201643a6345d8e/ui/message_center/views/notification_view_md.h [modify] https://crrev.com/cc2743d59d86aa00720a69a863201643a6345d8e/ui/strings/ui_strings.grd
,
Dec 19 2017
,
Dec 19 2017
Are there UX mocks for this yet?
,
Dec 19 2017
Sorry I forgot to link the mock from here: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZYhMpwexg3v6/files/MCFtDtB7WO4l5T_XIlIkONmqwMSJbxAVNpw
,
Jan 17 2018
megumihattori@ is going to work on the animation implementation. Thanks!
,
Jan 17 2018
sgabriel@: Can we have the asset of the send icon? Thank you!
,
Jan 18 2018
sgabriel@: Sorry i forgot to add you to this issue. Can we have the asset? Thank you!
,
Jan 18 2018
Asset attached.
,
Jan 19 2018
Thank you Sebastien!
,
Jan 19 2018
,
Jan 19 2018
,
Jan 19 2018
,
Feb 19 2018
|
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by yoshiki@chromium.org
, Oct 11 2017