New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773583 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Make PageInfo use PermissionManager to determine the current permission status

Project Member Reported by patricia...@chromium.org, Oct 11 2017

Issue description

Page Info should query PermissionManager always for permission information. Currently it asks the HostContentSettingsMap directly, except for in certain circumstances (embargo only?) where it will ask PermissionManager.

This bug is similar to Issue 739241, but for PageInfo.
 

Comment 1 by raymes@chromium.org, Oct 11 2017

Summary: Make PageInfo use PermissionManager to determine the current permission status (was: Handle the DSE Geolocation Setting in PermissionManager)
Thanks for filing. What I was trying to say on the code review was that currently that code looks like it's querying GetWebsiteSetting https://chromium-review.googlesource.com/c/chromium/src/+/710955/2/chrome/browser/ui/page_info/page_info.cc#779

I think it only queries PermissionManager in very specific circumstances? The result from PermissionManager should incorporate the DSE setting already I think. So I think the right long-term fix is just to make PageInfo be more accurate (like we did for Site Details). But I might be missing something, so let me know!

Comment 2 by raymes@chromium.org, Oct 11 2017

Components: UI>Browser>Bubbles>PageInfo
Oops, sorry, yeah you're right - I forgot PageInfo doesn't already use PermissionManager always (yeah I think currently only queries it sometimes). I didn't know the PermissionManager result already incorporates the DSE setting though, that's good :)
Description: Show this description

Comment 5 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 6 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt

Sign in to add a comment