New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773581 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Edit options are displayed on long tapping on Mobile bookmarks,Bookmarks bar and other bookmark.

Project Member Reported by pmadalla@chromium.org, Oct 11 2017

Issue description

App Version: 63.0.3237.0 Canary
iOS Version:10.3.5,11.0.1
Device : iPhone,iPad

Precondition :
1.Enable new bookmarks.
2.Have few bookmarks saved.

Steps to repro :
  1. Launch chrome.
  2. Tap on Bookmarks icon at bottom.
  3. Long tap on Mobile Bookmarks.
 
Observed results:
Edited folder, Move and Cancel options are displayed.

Expected results:
Edited folder, Move and Cancel options should not be displayed.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Dolphin/Safari/Firefox: NA
Bug reproducible on current stable build (App Version, iOS Version): No in M61 , New implementation M63
Bug reproducible on the current beta channel build (App Version, iOS Version): No, New implementation  in M63

Link to Video:
https://drive.google.com/a/google.com/file/d/0B--UpU2GW2Epa1hsbUVadW5lcG8/view?usp=sharing

 

Comment 1 by martiw@chromium.org, Oct 11 2017

Cc: mard...@chromium.org
Labels: -Pri-2 Pri-1
Status: Started (was: Untriaged)
Thanks pmadalla, 
feels like this is a P1 bug.
Cc: pinkerton@chromium.org noyau@chromium.org
Labels: ReleaseBlock-Beta
Thanks, Pramod. This is definitely an RBB too.

Comment 3 by martiw@chromium.org, Oct 11 2017

Cc: -martiw@chromium.org
Owner: martiw@chromium.org
Labels: M-63
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f72f248a4c834e34837cfaa2ddf89cbaed549b1

commit 0f72f248a4c834e34837cfaa2ddf89cbaed549b1
Author: Marti Wong <martiw@chromium.org>
Date: Wed Oct 11 23:15:35 2017

Disable the long press gesture on permanent nodes (new iOS bookmark ui)

Disable the long press gesture on permanent nodes which will bring out
context menu with editing and moving option.  Modify an egtest to
prevent this bug from happen again.

Bug:  773581 
Change-Id: I98237076b08c2a0b9e8280828a721b31ef76d356
Reviewed-on: https://chromium-review.googlesource.com/711540
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Marti Wong <martiw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508163}
[modify] https://crrev.com/0f72f248a4c834e34837cfaa2ddf89cbaed549b1/ios/chrome/browser/ui/bookmarks/bookmark_table_view.mm
[modify] https://crrev.com/0f72f248a4c834e34837cfaa2ddf89cbaed549b1/ios/chrome/browser/ui/bookmarks/bookmarks_new_generation_egtest.mm

Comment 6 by martiw@chromium.org, Oct 11 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on 64.0.3267.0 in iPhone 6plus(iOS 11.2 beta), iPhone 7(iOS 10.3.3) and iPad (iOS 11.1)

Long press on Mobile Bookmarks, Bookmarks Bar and Other Bookmarks will not display edit, Move and Cancel options

Sign in to add a comment