New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773580 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Long tapping on Bookmarks header shows up the context menu.

Project Member Reported by pmadalla@chromium.org, Oct 11 2017

Issue description

App Version: 63.0.3237.0 Canary
iOS Version:11.0.1
Device : iPhone

Precondition :
1. Enable new bookmarks.
2. Have few bookmarks saved.

Steps to reproduce : 
1. Launch chrome 
2. Tap on Bookmarks icon at bottom.
3. Tap on Mobile bookmarks > scroll the bookmarks upwards.
4. Long tap on Mobile bookmarks header.

Observed results:
Context menu is displayed.

Expected results:
Tapping on Bookmarks header should not be functional.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Yes
Bug reproducible on Dolphin/Safari/Firefox: Safari : NA
Bug reproducible on current stable build (App Version, iOS Version): No in M61, New implementation M63
Bug reproducible on the current beta channel build (App Version, iOS Version): No, New implementation M63

Link to :
https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpTUhjZlZPb3hVemc/view?usp=sharing

 

Comment 1 by sczs@chromium.org, Oct 11 2017

Cc: -martiw@chromium.org
Owner: martiw@chromium.org
Status: Assigned (was: Untriaged)
martiw@ could you PTAL.

Comment 2 by martiw@chromium.org, Oct 12 2017

Components: UI>Browser>History
Status: Started (was: Assigned)
Same issue also happen on history.  Working on the fix.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08a5d98853cab5240e703615e0e9d10a9be772f5

commit 08a5d98853cab5240e703615e0e9d10a9be772f5
Author: Marti Wong <martiw@chromium.org>
Date: Thu Oct 12 23:14:28 2017

Prevent long-tap on navigation bar shows menu (iOS bookmark & history)

Fix the bug by stop forwarding touch events from navigation bar (appBar)
to the table or collection view.

Bug:  773580 
Change-Id: I0a535af23abc1e848c3340a8a75faffbb3e64544
Reviewed-on: https://chromium-review.googlesource.com/716396
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Marti Wong <martiw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508525}
[modify] https://crrev.com/08a5d98853cab5240e703615e0e9d10a9be772f5/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/08a5d98853cab5240e703615e0e9d10a9be772f5/ios/chrome/browser/ui/history/history_panel_view_controller.mm

Comment 4 by martiw@chromium.org, Oct 12 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on build 64.0.3242.0 canary on iPhone 6+ iOS 11.1.beta , iPhone7+ iOS 10.3.3, iPad Pro 12'5 iOS 11 
Long tapping on Bookmarks header is no longer brings up the context menu.

Sign in to add a comment