New issue
Advanced search Search tips

Issue 773570 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

"Reset Translate Settings" does not clear translate_last_denied_time_for_language

Project Member Reported by napper@chromium.org, Oct 11 2017 
OS: Android

What steps will reproduce the problem?
(1) Go into settings > Set settings > Google Translate
(2) Click "Reset Translate Settings"
(3) On desktop look at "chrome://translate-internals"

What is the expected result?
All settings are cleared

What happens instead?
All settings except translate_last_denied_time_for_language are cleared.

Comment 1 by goog...@chromium.org, Oct 11 2017 

The button will trigger "translate_prefs->ResetToDefaults();"

https://cs.chromium.org/chromium/src/chrome/browser/android/preferences/pref_service_bridge.cc?type=cs&q=resetTranslateDefaults&l=733

So I believe the bug is inside that function.

Comment 2 by napper@chromium.org, Oct 11 2017

Owner: napper@chromium.org

Comment 3 by goog...@chromium.org, Oct 11 2017 

Seems in the ResetToDefaults(), translate_last_denied_time_for_language is cleared. https://cs.chromium.org/chromium/src/components/translate/core/browser/translate_prefs.cc?dr=CSs&l=201

Comment 4 by napper@chromium.org, Oct 11 2017 

It turns out that all the other translate preferences are syncable, but not translate_last_denied_time_for_language

https://cs.chromium.org/chromium/src/components/translate/core/browser/translate_prefs.cc?rcl=f45d5c38068ce3aa28a032ba241046dfc0e9ff55&l=541

Comment 5 by napper@chromium.org, Oct 11 2017

Owner: yyushkina@chromium.org
Yana, do you think that translate_last_denied_time_for_language should also be synced, to be consistent with the other settings?

Comment 6 by yyushkina@chromium.org, Nov 1 2017 

Hey Jon - in theory yes. In practice, if we're going to drop using these heuristics anyways, does it matter?

Comment 7 by yyushkina@chromium.org, Nov 1 2017

Owner: ----
Status: Available (was: Assigned)

Comment 8 by yyushkina@chromium.org, Mar 7 2018

Status: WontFix (was: Available)
Marking this as obsolete since we dropped heuristics on desktop

Comment 9 by yyushkina@chromium.org, Mar 7 2018 

And never used them on Android
►

Sign in to add a comment