New issue
Advanced search Search tips

Issue 773562 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Clean up in scoped_layer_animation_settings

Project Member Reported by wutao@chromium.org, Oct 11 2017

Issue description

In current files of scoped_layer_animation_settings, the member functions are not grouped properly and are not in the same order in .h and .cc.

Need to reorder and regroup the functions.
 
Shall I take this issue ?

Comment 2 by wutao@chromium.org, Oct 11 2017

Thanks bhagirathi.s@. I have uploaded a cl yesterday already.
https://chromium-review.googlesource.com/c/chromium/src/+/711321

There are other clean up such as converting base::MakeUnique to std::make_unique. You probably can create an issue and ask the owner if it is a good time to work on it?


Project Member

Comment 3 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe063b9208379e459ecdf186f075b3b7861cd9f4

commit fe063b9208379e459ecdf186f075b3b7861cd9f4
Author: wutao <wutao@chromium.org>
Date: Wed Oct 11 16:25:48 2017

Clean up scoped_layer_animation_settings.

In current files of scoped_layer_animation_settings, the member
functions are not grouped properly and are not in the same order in .h
and .cc. This cl reorders and regroups the functions.

Bug:  773562 
Change-Id: I3180f2e024ce8eaee5ef75ef2ba5c30db80054a1
Reviewed-on: https://chromium-review.googlesource.com/711321
Reviewed-by: Ali Juma <ajuma@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507999}
[modify] https://crrev.com/fe063b9208379e459ecdf186f075b3b7861cd9f4/ui/compositor/scoped_layer_animation_settings.cc
[modify] https://crrev.com/fe063b9208379e459ecdf186f075b3b7861cd9f4/ui/compositor/scoped_layer_animation_settings.h

Comment 4 by wutao@chromium.org, Oct 11 2017

Status: Fixed (was: Available)
Thanks  wutao@. Currently checking some other issue. I will check std::make_unique conversion if it is feasible and update. Thanks for the info.

Sign in to add a comment