New issue
Advanced search Search tips

Issue 773543 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

The transparency in AEC3 is sometimes not ideal

Project Member Reported by peah@chromium.org, Oct 11 2017

Issue description

The transparency in AEC3 is not always optimal in the sense that it is clear that a better transparency can be achieved.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/1f33a37565421d7a33149281456cad4a5ba3a5fe

commit 1f33a37565421d7a33149281456cad4a5ba3a5fe
Author: Per Åhgren <peah@webrtc.org>
Date: Wed Oct 11 07:28:09 2017

AEC3 tunings to increase the transparency

This CL changes the tuning of AEC3 to increase the transparency.
In particular:
-The present parameters are re-tuned.
-An oversuppression factor is added in the newly added soft-knee in
 the NLP gain. The purpose of this is to avoid fluctuations in the
 residual echo.
-The dynamics of the computed gain are bounded to ensure that the 
 specified gain characteristics are realizable without echo leakage.
 This also adds robustness against echo leakage in frequency regions
 that are poorly estimated.
 This change was needed to avoid echo leakage from the above 
 tunings.

Bug:  chromium:773543 , webrtc:8378 
Change-Id: If8acc41c1423a6a2fa6f8c4daf2735c86f0b529a
Reviewed-on: https://webrtc-review.googlesource.com/8262
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20231}
[modify] https://crrev.com/1f33a37565421d7a33149281456cad4a5ba3a5fe/modules/audio_processing/aec3/suppression_gain.cc
[modify] https://crrev.com/1f33a37565421d7a33149281456cad4a5ba3a5fe/modules/audio_processing/include/audio_processing.h

Is this finished?

Comment 3 by peah@chromium.org, Oct 19 2017

Labels: Merge-Request-63
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 20 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gov...@chromium.org, Oct 20 2017

Please merge your change to M63 branch 3239 by 4:00 PM PT today, Friday so we can take it in for next M63 dev release. Thank you.

Comment 6 by peah@chromium.org, Oct 20 2017

Sorry, my mistake. This actually made it into M63, so no merge needed.

Comment 7 by peah@chromium.org, Oct 20 2017

Labels: -Hotlist-Merge-Approved -Merge-Approved-63
Status: Fixed (was: Assigned)

Sign in to add a comment