AEC3 fails to detect the echo path delay in reverberant environments with moderate echo return loss |
|||||
Issue descriptionFor some setups located in reverberant rooms AEC3 fails to detect the echo path delay. In particular this seems to happen in setups where the echo is relatively weak in the microphone signal.
,
Oct 11 2017
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/f9e58227d293f960aaeb761552a14e0338f9a957 commit f9e58227d293f960aaeb761552a14e0338f9a957 Author: Per Åhgren <peah@webrtc.org> Date: Wed Oct 11 07:52:19 2017 Changed the aggregation of AEC3 matched filter delay estimates This CL changes the aggregation of the matched filter delay estimates in AEC3 to using a histogram approach. Bug: chromium:773541 , webrtc:8379 Change-Id: I5322c65858188599397ef5716fecdebc34852e6a Reviewed-on: https://webrtc-review.googlesource.com/8261 Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20234} [modify] https://crrev.com/f9e58227d293f960aaeb761552a14e0338f9a957/modules/audio_processing/aec3/echo_path_delay_estimator.cc [modify] https://crrev.com/f9e58227d293f960aaeb761552a14e0338f9a957/modules/audio_processing/aec3/matched_filter.cc [modify] https://crrev.com/f9e58227d293f960aaeb761552a14e0338f9a957/modules/audio_processing/aec3/matched_filter_lag_aggregator.cc [modify] https://crrev.com/f9e58227d293f960aaeb761552a14e0338f9a957/modules/audio_processing/aec3/matched_filter_lag_aggregator.h [modify] https://crrev.com/f9e58227d293f960aaeb761552a14e0338f9a957/modules/audio_processing/aec3/matched_filter_lag_aggregator_unittest.cc
,
Oct 11 2017
,
Oct 13 2017
Is this finished?
,
Oct 19 2017
,
Oct 20 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 20 2017
Please merge your change to M63 branch 3239 by 4:00 PM PT today, Friday so we can take it in for next M63 dev release. Thank you.
,
Oct 20 2017
Sorry, my mistake. This actually made it into M63, so no merge needed.
,
Oct 20 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by peah@chromium.org
, Oct 11 2017