New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773540 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

amd64-generic-telemetry failures

Project Member Reported by afakhry@chromium.org, Oct 11 2017

Issue description

There are 17 failures in telemetry_UnitTests. They seem to be related to devtools:


Example Errors:
[196/1125] telemetry.internal.actions.action_runner_unittest.ActionRunnerMeasureMemoryTest.testDeterministicMode:
   TracingUnrecoverableException: Exception raised while collecting tracing data:
   WebSocketConnectionClosedException: Connection is already closed.

[197/1125] telemetry.internal.actions.action_runner_unittest.ActionRunnerMeasureMemoryTest.testRealisticMode
   ChromeTracingStoppedError: Exceptions raised when trying to collect Chrome devtool tracing:
   Error when collecting Chrome tracing on devtools at port 41266:
   TracingUnrecoverableException: Exception raised while collecting tracing data:
   WebSocketConnectionClosedException: Connection is already closed.


[344/1125] telemetry.internal.browser.browser_unittest.BrowserTest.testForegroundTab
   AssertionError: <telemetry.internal.browser.tab.Tab object at 0x7db184c0efd0> != <telemetry.internal.browser.tab.Tab object at 0x7db184bfa350>


[1106/1125] telemetry.core.tracing_controller_unittest.TracingControllerTest.testGotTrace
   AssertionError: Tracing must be running to clock sync.


Full log is here: https://00e9e64bac55bf0b845611d8e1b6b409839e85831fc32b4d47-apidata.googleusercontent.com/download/storage/v1/b/chromeos-image-archive/o/amd64-generic-telemetry%2FR63-10020.0.0-b12740%2Fvm_test_results_2%2Ftelemetry_suite%2Ftest_harness%2Fall%2FSimpleTestVerify%2F1_autotest_tests%2Fresults-1-telemetry_UnitTestsServer%2Ftelemetry_UnitTestsServer.user%2Ftelemetry_UnitTests%2Fdebug%2Ftelemetry_UnitTests.DEBUG?qk=AD5uMEs7JwrTZG3ZekyhqOIBzxoXbCQrOxpBi1HDuBmFnVLz3UttH_wCQXFk_DHQq_75bUnASCRCd6T0gQ0xayi0ETAuBlzFL_u2BXHzjhsRXOyLKW2O331hOHKqSl25tZF-gj51kHFEfiZ8lHvz2HM5e84wVWXXq-KW8OvAQwG2jZfpYwWTmHnYdunf3qL30Z_wpSNLSb88rpRggyZMBiWPAmmCRpgwFCPskeZZbcE4zXt3CVTCEZD1ynZZbzYAlujv8HVdJ6Zu-RzAFdmSSvmJqHeP5uStyNnTidK-FkBd1MU2MGztQVZkjsWjyQ8g2xcIIRZOBf-aeRnX_eDuICiOc3WcJxiBEC08IWQlFucNcI-KZ0GXVmYNZrpSDHR28xxxR6Vslyb2JfpE18q_J6YBaN0zs65uNEnlqXjAnYpebeZ-g2VgVYz6Bhuf8wFRAtERYkaWm0bqtxzceFevyH5ZXpcBByzdtEfQGO_oIKT5vNzaVNIT6C5iZsmKHya3rFfFv1egE29l7vv0fLvrkAvIMOQBL-WvkbV0SunV4Uvu3quryCFdVJZ0dNUPS_ASQEVhCE7uKlTjX2sHLbDwJcC9I37fN9e6wiwGONd1I4QD8DxVMc7IO-MfoCjawEVqH3d7vtrdjMNOhpgqESjcLTkmWnimHp3C0s9CDVeUvsmQxVs-yZvlLbSf6bj5j2VkQZ-8t6PzIs5hQtIABuLAA3mkwGp4piBdYA-CqVxeiBQ_nrpeW1fn0pJ2s3HnG6Ntqk0XkQHg1i_09eJulSas5rrnVj5JtDz3p5IGKNwYKceCuiO2R3JfX2qRFUqxZrAPeJgrlS7ueJepAHEJSm0462xRiDX1tBdPYq4YW9ntlqZPIzZEl_AmDFjPeY0VGdOPWS9g_3TJO25LttooKOw-t6qdZZeEoO5uFjecrpJJfXJbjnSvnjjeS_8tm5YFmhEhbRH_qCLmfVLS4PqeZvN1KT6F7kCgDT8N_xczCDyB5_U-3mG4c8RHAKgp_oASm6EORHxeSFKVFsI-ZHP0robdm6oIgf9x6hZzlVzEV60jDPUj2zam1dGClwSRck-1nivsn0iAfPaZyWT3fHAzbokAWMGH-zm4gOIuHA



 
Cc: chiniforooshan@chromium.org
I suspect this is related to Ehsan's work
Owner: chiniforooshan@chromium.org
Status: (was: Untriaged)
What is the link to the bot? I cannot see the full log. It says:

{"error":{"errors":[{"domain":"global","reason":"lockedDomainExpired","message":"Locked Domain Expired"}],"code":401,"message":"Locked Domain Expired"}}
Cc: jonr...@chromium.org
Status: Started
I think https://chromium-review.googlesource.com/c/chromium/src/+/713558 will fix this.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1d7b322400fe1983c8be1be90de1792222cb1ab

commit f1d7b322400fe1983c8be1be90de1792222cb1ab
Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Date: Thu Oct 12 00:15:48 2017

Tracing: fix a bug in CrOS Tracing

The bug is that if the tracing config does not allow system tracing the CrOS
tracing agent correcly does not start tracing but may try to stop tracing and
consequently crash (the stop tracing task runner is not set).

Bug= 773540 

Change-Id: I6fec0734aee851cacf7ce2599716529dcfd8ffa5
Reviewed-on: https://chromium-review.googlesource.com/713558
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508188}
[modify] https://crrev.com/f1d7b322400fe1983c8be1be90de1792222cb1ab/content/browser/tracing/cros_tracing_agent.cc

Status: Fixed (was: Started)
It's green again: https://build.chromium.org/p/chromiumos.chromium/builders/amd64-generic-telemetry

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: archived (was: Fixed)

Comment 10 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment