New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 773539 link

Starred by 1 user
Status: Fixed
Owner:
█ robert...@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
wylieb@chromium.org
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

/waterfall/config does not accept integers when float is expected.

Project Member Reported by robert...@chromium.org, Oct 11 2017 
The issue happens with "swarming_task_cushion" and perhaps other values.

When the value is set to 2.0 the validation succeeds, but once stored, the value shows in the page as 2 (with the .0 part removed) and trying to save again fails the validation (expected float, got int)

The handler should not require the .0 trailing for floats.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9a51cf4ac6e6bec8ab7db8ee66a3f221b12f7822

commit 9a51cf4ac6e6bec8ab7db8ee66a3f221b12f7822
Author: Shuotao Gao <stgao@chromium.org>
Date: Wed Oct 11 16:55:39 2017

[Findit] Make config validation accept int values as float.

This is a temporary fix.
Bug:  773539 
Change-Id: I898d73e8643c96bfc779c4a350175f2fdb64cb2e
Reviewed-on: https://chromium-review.googlesource.com/713456
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/9a51cf4ac6e6bec8ab7db8ee66a3f221b12f7822/appengine/findit/handlers/test/config_test.py
[modify] https://crrev.com/9a51cf4ac6e6bec8ab7db8ee66a3f221b12f7822/appengine/findit/handlers/config.py

Comment 2 by st...@chromium.org, Nov 9 2017

Status: Assigned (was: Untriaged)

Comment 3 by robert...@chromium.org, Dec 6 2017

Owner: robert...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/97562102965c985d908c5bc775004219cb56182e

commit 97562102965c985d908c5bc775004219cb56182e
Author: Roberto Carrillo <robertocn@google.com>
Date: Thu Dec 07 07:26:22 2017

[Findit] Refactor config validation.

This new approach rather than return a boolean, returns a list of errors
that can hopefully be more helpful for determining why a given config is
rejected by the handler.

R=stgao,lijeffrey,wylieb
BUG= 773539 

Change-Id: I9d4e2276a3a7f4fc31820cadb8483973de8d8b7e
Reviewed-on: https://chromium-review.googlesource.com/809719
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>

[modify] https://crrev.com/97562102965c985d908c5bc775004219cb56182e/appengine/findit/handlers/test/config_test.py
[modify] https://crrev.com/97562102965c985d908c5bc775004219cb56182e/appengine/findit/handlers/config.py

Comment 5 by robert...@chromium.org, Jan 5 2018

Status: Fixed (was: Started)
►

Sign in to add a comment