use_clang_coverage can be used with is_component_build=true even though it breaks clang coverage |
|||
Issue descriptionJust asserting !(use_clang_coverage && is_component_build) makes it impossible to build anything without is_component_build=false (leaving it blank won't suffice). The consequences of forcing everyone to do this should be investigated before this change is made.
,
Oct 11 2017
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc786b3eb32eb1e4c9b844fce74d3e6f5ee1b4b9 commit cc786b3eb32eb1e4c9b844fce74d3e6f5ee1b4b9 Author: Jonathan Metzman <metzman@chromium.org> Date: Wed Oct 11 15:07:45 2017 Add warnings not to use "is_component_build=true" when using use_clang_coverage. Bug: 773530 Change-Id: I7d9002279230b6aa6efaf9cf5ed09117ae4e6ff0 Reviewed-on: https://chromium-review.googlesource.com/711217 Reviewed-by: Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#507983} [modify] https://crrev.com/cc786b3eb32eb1e4c9b844fce74d3e6f5ee1b4b9/build/config/coverage/coverage.gni [modify] https://crrev.com/cc786b3eb32eb1e4c9b844fce74d3e6f5ee1b4b9/testing/libfuzzer/coverage.py
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/301ce027adbc5555dec9ac7e449af1732ce3a5f9 commit 301ce027adbc5555dec9ac7e449af1732ce3a5f9 Author: Jonathan Metzman <metzman@chromium.org> Date: Mon Oct 16 15:43:28 2017 Add assertion preventing is_component_build=true from being used with use_clang_coverage. Bug: 773530 Change-Id: Ib0997ffdead67437f61e279791a7a8887cbe807f Reviewed-on: https://chromium-review.googlesource.com/714279 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#509058} [modify] https://crrev.com/301ce027adbc5555dec9ac7e449af1732ce3a5f9/build/config/coverage/coverage.gni [modify] https://crrev.com/301ce027adbc5555dec9ac7e449af1732ce3a5f9/testing/libfuzzer/coverage.py
,
Oct 19 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by metzman@chromium.org
, Oct 11 2017